From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: <linux-rtc@vger.kernel.org>
Subject: Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127 watchdog functionality
Date: Wed, 30 Aug 2017 09:45:06 +0200 [thread overview]
Message-ID: <4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk> (raw)
In-Reply-To: <20170829150739.apyt4lxguypebkbm@piout.net>
On 2017-08-29 17:07, Alexandre Belloni wrote:
> Hi Sean,
>
> I know this patch is 7 months old but I never had the time to write a
> proper reply.
>
> This is using a pretty old API. Can you register a proper watchdog using
> the watchdog subsystem (see drivers/watchdog)? Also, please copy the
> watchdog maintainers.
>
> I understand this will require a significant rewrite effort but the
> final code will be quite cleaner.
Hi Alexandre
I unfortunately don't have access to the hardware anymore...
I think it would be very risky to rewrite the whole code without testing
it :-)
Yes this driver is quite hacky in some ways. It could be nice if the
watchdog part for this could be in the driver/watchdog and the rtc part
here. Maybe we could have 2 entries in the devicetree that shared the
same i2c device address.
/Sean
next prev parent reply other threads:[~2017-08-30 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 12:36 [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127 watchdog functionality Sean Nyekjaer
2017-01-20 12:36 ` [rtc-linux] [PATCH 2/2] rtc: pcf2127: add support for pcf2127 tamper functionality Sean Nyekjaer
2017-08-29 15:07 ` [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127 watchdog functionality Alexandre Belloni
2017-08-30 7:45 ` Sean Nyekjær [this message]
2017-08-30 7:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox