From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from classfun.cn (unknown [129.204.178.38]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09B91DF53; Sat, 7 Sep 2024 14:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=129.204.178.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725719643; cv=none; b=OhTpi4ifz/V5xbrSpTN1O5Z8f4NA4K6zBf4ACVKi0yJv/CR1D4OMWe2pe6PmsguKCFLqoKu8j0FI2M4K7CCjL6QdVlXGWP5oBsReiY/c6Hw2wg8O48PM2CkuO4fDSdRxqlP5uvvxf676Hjj5dHzgHEb5uyUPkqG1aiJVa9wxGEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725719643; c=relaxed/simple; bh=uzKsDDJjS7gq8EcZmXUPlxPJDGZWlwn06A72RrFvCaY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DqlKBXsdRv4Fm79YBA9UqFKc/VwIh9/bRUA5k3ykAe8dxEaGwBYlt0MJXTqmsWNF57rYI+ofTIsi4x5bkWeOtzQP+SRsINzBndXjX2kES+Ss614Bzkk0Myy/Oh6jChJDyUlGp8b1oaefZIKBQYoL7FBVQsa3J8ICqEQoVLrebwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=classfun.cn; spf=pass smtp.mailfrom=classfun.cn; dkim=pass (1024-bit key) header.d=classfun.cn header.i=@classfun.cn header.b=DSNlpm8V; arc=none smtp.client-ip=129.204.178.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=classfun.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=classfun.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=classfun.cn header.i=@classfun.cn header.b="DSNlpm8V" Received: from [192.168.0.160] (unknown [14.155.100.110]) (Authenticated sender: bigfoot) by classfun.cn (Postfix) with ESMTPSA id 2278778A01; Sat, 7 Sep 2024 22:33:56 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.11.0 classfun.cn 2278778A01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=classfun.cn; s=default; t=1725719638; bh=gG2BH1+dXG7ZoJOt2ZX2FJLzrZcgshauVLlXVmZq6sM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DSNlpm8Vqtpho/RR7/MrKCNIEHFUFwwo/5l+BjIiUEgoS/ohM5XFx/jEygmd6VrWX Ficq4hrX/KNy045+dpBwYrC5HAtq1+QfDxuRCBmvXQ8b82WTjXTLr797wpeVzIyaVz 0LwzUe5E6XCPOlgoplXM/RpP0R2GK63DfSfLnJsU= Message-ID: <43918eda-c4e8-471a-9de4-ea72bb090803@classfun.cn> Date: Sat, 7 Sep 2024 22:33:55 +0800 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU To: Markus Elfring , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: LKML , Alexandre Belloni , Chukun Pan , Conor Dooley , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jean Delvare , Krzysztof Kozlowski , Lee Jones , Pavel Machek , Rob Herring , Sebastian Reichel , Wim Van Sebroeck References: <20240906093630.2428329-2-bigfoot@classfun.cn> Content-Language: en-US From: Junhao Xie In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2024/9/7 16:44, Markus Elfring wrote: > … >> +++ b/include/linux/mfd/photonicat-pmu.h >> @@ -0,0 +1,86 @@ > … >> +#ifndef _PHOTONICAT_PMU_H >> +#define _PHOTONICAT_PMU_H > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > > Regards, > Markus Thanks for your suggestion, does this look better? #ifndef MFD_PHOTONICAT_PMU_H #define MFD_PHOTONICAT_PMU_H Best regards, Junhao