From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460083B9D9A for ; Tue, 15 Sep 2026 06:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789452495; cv=none; b=YhKGVhGrW0oBDVUdQqJx4Rf9mbOWD4TAYLK8DlZLSaZxGZZwpdIp96jQfLO7kFthntcokRruAAznKbpbaN053k7Nuu8PLZAJPSIHWx4FmG3WJH7jAKu1kLmyz5vMpyvPSr6U5VaKwC/wVI2seqaaYkWq/NJvVYrbw3h/0R7krx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789452495; c=relaxed/simple; bh=PAuNvntAEAuzj4Nz9wV7sdS6zNhgaj7KUz8bvciwMOg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jda2yo/Gx+EvyhOk1j7CxXnnja8tWXcPhox8aV5PC7A02FR6JEaRZ7b3akJ8TadkIIXmXfwqXvSmjUeYbC1L3eP/9leYNBMIopI/L7Xb4JF6Hvl16tI9X4FFnV88M3AhIQTVrxIQZjEpAtkLqu3dLBM2VkYgrrSg3JAYWZwEkGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=swpShztk; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="swpShztk" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso4051624a91.1 for ; Mon, 14 Sep 2026 23:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789452493; x=1790057293; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YJ/ZVEdkNsjrbjg2YrtoA+pGCWrHgTsXZF53fBuFvuY=; b=swpShztkdatBxzX+vvvuFwczoHYuYNBwAAjTIkjGLrG+cXahftXDvVAt00q+kwiicW AgokXZ4LVdqJ1TxtkBzCCQFi9511SFdWdX7iTMErNl8t0kbhkdGd3q6SBJnjJHwbWmSP tQoMISBy5MOSvgRLj086k2ut2V3F4uN+KUyQ4jigoU754qHrSZPrvk0CHoUrdhaHHJQO qRKyIZ63JDWxrlUUg1lL8/pxROVw1Wuqv7PlJDu9BjivbHJOao12GSBOUQ1JvukM/SoM MsNSOX9Bp/RwCZfPZCfQvvEcXWKp4b9q0reQuqIQPUBs0xHTSFe6lL/qIaavcQvqy6+u DuWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789452493; x=1790057293; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YJ/ZVEdkNsjrbjg2YrtoA+pGCWrHgTsXZF53fBuFvuY=; b=VA4WxWCYjIofwK5TEAKR7SC6jPLD85qnHW0ESVPoDUdzg5a2Z4L3n6PWF0wjws7YTA ezOefcKmY7XiN0BGVBsTN5E9DYTSJs4+CzZxPZFDGSC9Id3VFltY4Nn2m0Y/xbCgI9XH WxTX2Ev8vjQzubWosa2INeAk2XtwGhjfbsBNE7rpS39+GyKrGweAcYkpn968DZS9NRSV a0Wwt9R9hNEdjtGrVSTdAh1N2stqYuxMsz9ADFXiksgp/TwAJDxnUpcyIBxtH5zqW04z dz6i//acCqDHAGT2CzBQAKA7ukWbJzTc37WacR4Blbq7r6sWr4PNDGikdEFGbvaPHSWx oZSw== X-Forwarded-Encrypted: i=1; AKwUvBwOaqnxa6T9k5fwHwPl8CTq6/9Dmc5qz5aJxjR+7KmXbkcTID8MISB+5ioEpgnpA2umqYH5kncO9X4=@vger.kernel.org X-Gm-Message-State: AFuF++lw8zZs7mGvkx+Qxs86PojPv/RPY2qbI43aPYstX7/GDv0t/7H7 yFtHOjROeEnCguA1YLFUA+GhmZ1sTkC+Fwivn20CqjZNrzBR9PA0EYuhI4UUpA== X-Gm-Gg: AYBFou3F9C7JbbxmNSc5bp5oaGoCapi5eVvdrqxnT9PUn7kvQYY2QOqPrSoNkB+3YGS OLBGGYMCT0F8beVm5mXhoD6KOxvTiSWIj8wJ+K80HWgPSLvZwoqgFxJGhSGYMazCfX0gDoqwZlw /qvBlq6EK88CEwU01sJTwKQ1AiSDVOYyROvWK20eX13B55GG0DpRmKo06QBomI0tSaZNdsbe0y1 +59fdRHULfPh3hNqhbumAo8an5bGt2pSkI8UMc/W9pyuRhj/4N3xL2LkdJGvrUXhnL8VY4+rEBo uuchSdQVvup0RLmzOZeSyGlDvHJzkISENZw5PfQjHwL5GfNaAm/gP+Zu2emdB4PWzWx1DRBauNI lEJvJ7r6lFyhUmS75JZXk7Sstu7zqAiMe3PCET0HVhQ/B/CFrZxpfYMe4EPzR28od3nyZSXHlnk Cs7rILHy5L30k+Bw9F655dzL78Sx0A1XNWDKzzgtBHYnxE+WMzFlei9cbH9PYapbkGTUpicKbFR OaOn+UlimkvsAWDgCxW1zFFKakMQINig4+lnorSqHeAGlpc7ZZdQlQ= X-Received: by 2002:a17:90b:4a8c:b0:39e:261:4e12 with SMTP id 98e67ed59e1d1-39e02615623mr3589464a91.23.1789452493406; Mon, 14 Sep 2026 23:08:13 -0700 (PDT) Received: from [172.19.1.47] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dfda7d765sm3146170a91.10.2026.09.14.23.08.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 23:08:12 -0700 (PDT) Message-ID: <4997b79c-fb9d-44be-a9ee-1af2d6e5d0f9@gmail.com> Date: Tue, 15 Sep 2026 14:08:09 +0800 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtc: ma35d1: fix permanent clock reference/enable-count leak in probe To: Cong Nguyen , Jacky Huang Cc: Shan-Chun Hung , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260914131850.2331670-1-congnt264@gmail.com> Content-Language: en-US From: Jacky Huang In-Reply-To: <20260914131850.2331670-1-congnt264@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > diff --git a/drivers/rtc/rtc-ma35d1.c b/drivers/rtc/rtc-ma35d1.c > index cfcfc28060f6..43358d68565a 100644 > --- a/drivers/rtc/rtc-ma35d1.c > +++ b/drivers/rtc/rtc-ma35d1.c > @@ -221,14 +221,10 @@ static int ma35d1_rtc_probe(struct platform_device *pdev) > if (IS_ERR(rtc->rtc_reg)) > return PTR_ERR(rtc->rtc_reg); > > - clk = of_clk_get(pdev->dev.of_node, 0); > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > if (IS_ERR(clk)) > return dev_err_probe(&pdev->dev, PTR_ERR(clk), "failed to find rtc clock\n"); > > - ret = clk_prepare_enable(clk); > - if (ret) > - return ret; > - > if (!(rtc_reg_read(rtc, MA35_REG_RTC_INIT) & RTC_INIT_ACTIVE)) { > ret = ma35d1_rtc_init(rtc, RTC_INIT_TIMEOUT); > if (ret) > -- > 2.25.1 > Hi Cong, Thanks for fixing this. The conversion to devm_clk_get_enabled() correctly fixes the clock reference and enable-count leak while preserving the RTC clock behavior during the device lifetime. Reviewed-by: Jacky Huang Best regards, Jacky Huang