From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289BF258EFF; Thu, 21 Aug 2025 15:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789939; cv=none; b=RevQDLx98HCYOx+zL5K09I9ls3RFd+pYQ9Tmx1ybs+1/qYT5oncieUNBXDPnZ2ktsk384rCzeiP5p7lYAHgdPncL3So/JbTDECOCjO2MjKpCXz4OUgprK+47vrNACaF5qBeHxPwJQCU5V6gXT3SbIPLIjU3uHizIpHEXXydczQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755789939; c=relaxed/simple; bh=9kJqLOf6Qe+TXpNf2uvky1bKvhlkOmQpjYLqd2IEmos=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=S9hztsJYByeBoYhw4f051gksZ++O4XKbdGHCIiFFw7wUqhD/IBD3DRQy4Tw3kJkRz0RAvKn7QE1Ofs2ooKCPdQK5t2I4ITwblBQ72SsFQZAmtI4B/HogUMgBMdIxUCKa9GDjGveZXMRRoNP+6QdeqQ2txqgNTBX/vyjkTQ38HGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n8g9HanS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n8g9HanS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15E47C4CEEB; Thu, 21 Aug 2025 15:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755789939; bh=9kJqLOf6Qe+TXpNf2uvky1bKvhlkOmQpjYLqd2IEmos=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=n8g9HanS2lu636ESY7KmSZ/Zei+gIK6ydMzOks0Nf/9xeHezuQwjFM0Ty5bJP+6+R bvGK3jB4HUtLnTbqfwveFa4ZZxEdi3RR/q+V858X1muPPWBwHDnBR3bwpiKaNM785p RKFBJqjhDfhEd5yk3d/s1ek51x55nrlL5zMF4g4zxTOF19AoL4aJeoiMiMZJdxOTIA 81oIfKUTxKRQp2SBAsZNAXU8bjZmnuy5L2wvEQjkGFB/3QpUjKERLhqIc9YCNWP0iU UPmQcCwuQx5U62WvrKig5WfLkPpq4rL1E1u2bvuM4tkbOC2aTOtpUEu1Au0oLoOWn+ sGgym0VGzddZQ== Message-ID: <4a95cbf3-b3ae-4b26-8db2-dd5cf14a4c0c@kernel.org> Date: Thu, 21 Aug 2025 17:25:32 +0200 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Sven Peter Subject: Re: [PATCH 2/8] dt-bindings: hwmon: add Apple System Management Controller hwmon schema To: James Calligeros , Rob Herring Cc: Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Lee Jones , Krzysztof Kozlowski , Conor Dooley , Alexandre Belloni , Jean Delvare , Guenter Roeck , Dmitry Torokhov , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org References: <20250819-macsmc-subdevs-v1-0-57df6c3e5f19@gmail.com> <20250819-macsmc-subdevs-v1-2-57df6c3e5f19@gmail.com> <20250819201537.GA1223169-robh@kernel.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20.08.25 01:22, James Calligeros wrote: > Hi Rob, > > On Wed, Aug 20, 2025 at 6:15 AM Rob Herring wrote: >> [...] >>> + apple,fan-maximum: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + pattern: "^[A-Za-z0-9]{4}" >>> + description: The maximum speed the current fan can run at >>> + apple,fan-target: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + pattern: "^[A-Za-z0-9]{4}" >>> + description: Writeable endpoint for setting desired fan speed >>> + apple,fan-mode: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + pattern: "^[A-Za-z0-9]{4}" >>> + description: Writeable endpoint to enable/disable manual fan >>> + control >>> + label: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: Human-readable name for the sensor >> >> Surely more than apple,key-id is required? How would it be useful with >> only that? You can know how many fans you have, but have no info or >> control over them? > > The key specified in apple,key-id is the fan's current speed, which is the > only key strictly required to enumerate the presence of a fan in the system. > All of the other keys are optional information that are only really useful > when implementing manual fan control, which is itself optional as the platform > really expects the SMC firmware to have control over fan speeds at all times. Can we at least also require the label? Then we have the SMC key and a human readable representation which is already useful. Sven