From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C3ED15480; Fri, 3 Nov 2023 14:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Is2OgnZM" Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0579CD45; Fri, 3 Nov 2023 07:09:32 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5afabb23900so25199677b3.2; Fri, 03 Nov 2023 07:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699020571; x=1699625371; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=sIKyxdcVNpKFBly0hFFv+ZdrlRZfkg9V+7hrvUWInms=; b=Is2OgnZMJ3GvBxZfJgCAzAOUm5qa6uKsFlorxS50AGkhKzq9EiAtBfV1SupMXztTdR bIVjxmMEyWSll7ydcEBoOAJscT5ZfDKFkLYlLXdMWs3hjypu596/e2jkihrc5skqSXwV eGE7cMEW0NpE0sY1+1+HCTqrQgdhiOmV0nwRdQgqj03SevHPQYKV9VCJaIv035HQ94VU nmdB5wT3/NA3jleBKohS7X2zP1oqlMBd3g05q1Rr+4wsXw3hlC371I8ztxIRQVU5fHkP bmUh+kUiITlvU2B4qln6KjYr7xVrfMzBxwVUXLrDjRkD94a0c0QKpizS5hT063VzGj9M RWbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699020571; x=1699625371; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sIKyxdcVNpKFBly0hFFv+ZdrlRZfkg9V+7hrvUWInms=; b=eNRGNP0lyuQqb5au1yDpO47MvImeu5byo0BjltKgqFgplkfeDrshCQEH/jHBTigTvG cHVC8ZUkZ7wPR3HN/tgSX1CGvFPRuy8FDt4l6AsCMyRzSD7m9Twba/NbwwUL8ROCh8nV WashV31Zbtn3vQkoEFaKwAY1W9W1J8xc4Shm+9hicHYq3Ky/Yh+yLImQFcDcLhDJGa8t FS/c5SXe41Tfi7fhrR7K0+T6ZTPGTW+9wqeVHvSO+Bk9tSKjWuKe2AmyBIc3GDs8hUBa XECOEaOigQ51L7Q44P6vjyiVgiJKlzOdBgInEh+P0t2u/Q6fEnTzVZGFo8EjkgDBvb1T G/nQ== X-Gm-Message-State: AOJu0Yz0UOMoKzLmfidxwOHY0iAblRasVGzgIwWaaGjC8Kx6F9j1w218 KPffyItqmc8YCDqEk9Jtkfs= X-Google-Smtp-Source: AGHT+IFYBe3Ss3fQT6KU2ro2SQ4zvKkmUxeeR622XhlW78RW7hPh5nrvUmXGJ4bwJ3mz4TGqc7klGg== X-Received: by 2002:a81:9a05:0:b0:5a7:b723:8fa3 with SMTP id r5-20020a819a05000000b005a7b7238fa3mr2580452ywg.26.1699020571074; Fri, 03 Nov 2023 07:09:31 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id r125-20020a0de883000000b005a7fbac4ff0sm966265ywe.110.2023.11.03.07.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Nov 2023 07:09:30 -0700 (PDT) Sender: Guenter Roeck Message-ID: <5451ac26-c498-4af5-b3fa-fe2265433ccc@roeck-us.net> Date: Fri, 3 Nov 2023 07:09:27 -0700 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] rtc: add pcf85053a Content-Language: en-US To: Carlos Menin , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jean Delvare , Sergio Prado References: <20231103125106.78220-1-menin@carlosaurelio.net> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20231103125106.78220-1-menin@carlosaurelio.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/3/23 05:51, Carlos Menin wrote: > Add support for NXP's PCF85053A RTC chip. > > Signed-off-by: Carlos Menin > Reviewed-by: Sergio Prado > --- [ ... ] > +static int pcf85053a_bvl_to_mv(unsigned int bvl) > +{ > + long mv_table[] = { > + 1700, > + 1900, > + 2100, > + 2300, > + 2500, > + 2700, > + 2900, > + 3100, How are those numbers determined ? The datasheet gives voltage ranges. I'd have assumed that the center of those ranges is chosen, but for the most part it is the maximum, except for 2900 which is a bit above center and 3100 for "> 3.0V". Not that I care too much, but it seems to me that using the center voltage for each range would be more consistent. > +static int pcf85053a_hwmon_register(struct device *dev, const char *name) > +{ > + struct pcf85053a *pcf85053a = dev_get_drvdata(dev); > + struct device *hwmon_dev; > + > + hwmon_dev = devm_hwmon_device_register_with_info(dev, name, pcf85053a, > + &pcf85053a_hwmon_chip_info, > + 0); This won't compile if CONFIG_HWMON=n or if CONFIG_RTC_DRV_PCF85053A=y and CONFIG_HWMON=m. Guenter