From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rtc-linux+bncBCS7NNUK74ORB5HQTKVQKGQEAONK6EA@googlegroups.com>
Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175])
        by gmr-mx.google.com with ESMTPS id su3si83198lbb.1.2015.05.27.23.40.52
        for <rtc-linux@googlegroups.com>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 27 May 2015 23:40:52 -0700 (PDT)
Received: by lbcue7 with SMTP id ue7so21762968lbc.0
        for <rtc-linux@googlegroups.com>; Wed, 27 May 2015 23:40:52 -0700 (PDT)
Message-ID: <5566B86F.7030209@telliq.com>
Date: Thu, 28 May 2015 08:40:47 +0200
From: Jan Kardell <jan.kardell@telliq.com>
MIME-Version: 1.0
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
CC: Alessandro Zummo <a.zummo@towertech.it>,
 rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
 Vincent Donnefort <vdonnefort@gmail.com>,
 Dan Carpenter <dan.carpenter@oracle.com>, oen@telliq.com
Subject: [rtc-linux] Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we
 read an invalid time.
References: <1432730896-13423-1-git-send-email-jan.kardell@telliq.com> <20150527185352.GJ2185@piout.net>
In-Reply-To: <20150527185352.GJ2185@piout.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Reply-To: rtc-linux@googlegroups.com
List-ID: <rtc-linux.googlegroups.com>
List-Post: <http://groups.google.com/group/rtc-linux/post>, <mailto:rtc-linux@googlegroups.com>
List-Help: <http://groups.google.com/support/>, <mailto:rtc-linux+help@googlegroups.com>
List-Archive: <http://groups.google.com/group/rtc-linux
Sender: rtc-linux@googlegroups.com
List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe>, <mailto:rtc-linux+subscribe@googlegroups.com>
List-Unsubscribe: <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,
 <http://groups.google.com/group/rtc-linux/subscribe>

Alexandre Belloni skrev:
> Hi,
>
> On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
>> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
>>   		pcf8563->voltage_low = 1;
>>   		dev_info(&client->dev,
> Aren't dev_err or dev_warn more appropriate? You used dev_err in your
> first patch, what made you change your mind?
Your comment to the first patch. But I interpreted it to broadly.
I'll change it back to dev_err.
>
>>   			"low voltage detected, date/time is not reliable.\n");
>> +		return -EINVAL;
>>   	}
>>   
>>   	dev_dbg(&client->dev,

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.