From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Fabio Estevam <festevam@gmail.com>,
rtc-linux@googlegroups.com,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [rtc-linux] Re: [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
Date: Sat, 04 Jul 2015 20:54:44 +0200 [thread overview]
Message-ID: <55982BF4.3020303@free-electrons.com> (raw)
In-Reply-To: <20150704184216.GA5497@piout.net>
Hi Alexandre,
On 04/07/2015 20:42, Alexandre Belloni wrote:
> Hi Fabio,
>
> On 04/07/2015 at 15:27:34 -0300, Fabio Estevam wrote :
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Remove the 'flags' variable in order to fix the following warning:
>>
>> drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
>>
>
> Thank you but I'm pretty sure that one is fixed (that is the fourth
> patch to do so) ;)
Well, it should be fixed however none of the patch sent were merged in Linus tree yet...
Thanks,
Gregory
>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> drivers/rtc/rtc-armada38x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c
>> index 4b62d1a..2b08cac 100644
>> --- a/drivers/rtc/rtc-armada38x.c
>> +++ b/drivers/rtc/rtc-armada38x.c
>> @@ -88,7 +88,7 @@ static int armada38x_rtc_set_time(struct device *dev, struct rtc_time *tm)
>> {
>> struct armada38x_rtc *rtc = dev_get_drvdata(dev);
>> int ret = 0;
>> - unsigned long time, flags;
>> + unsigned long time;
>>
>> ret = rtc_tm_to_time(tm, &time);
>>
>> --
>> 1.9.1
>>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-07-04 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 18:27 [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time() Fabio Estevam
2015-07-04 18:42 ` [rtc-linux] " Alexandre Belloni
2015-07-04 18:54 ` Gregory CLEMENT [this message]
2015-07-04 19:02 ` Alexandre Belloni
2015-07-14 13:06 ` Fabio Estevam
2015-07-14 22:05 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55982BF4.3020303@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox