From: Keerthy <a0393675@ti.com>
To: Tony Lindgren <tony@atomide.com>, Keerthy <j-keerthy@ti.com>
Cc: <linux-omap@vger.kernel.org>, <pawel.moll@arm.com>,
<galak@codeaurora.org>, <paul@pwsan.com>,
<alexandre.belloni@free-electrons.com>,
<akpm@linux-foundation.org>, <johan@kernel.org>,
<grygorii.strashko@ti.com>, <rtc-linux@googlegroups.com>,
<bcousson@baylibre.com>, <nm@ti.com>,
<devicetree@vger.kernel.org>, <t-kristo@ti.com>
Subject: [rtc-linux] Re: [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs
Date: Tue, 11 Aug 2015 23:24:26 +0530 [thread overview]
Message-ID: <55CA36D2.3080509@ti.com> (raw)
In-Reply-To: <20150811125515.GN4215@atomide.com>
On Tuesday 11 August 2015 06:25 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [150810 02:31]:
>> @@ -371,8 +372,10 @@ IS_OMAP_TYPE(3430, 0x3430)
>> #ifdef CONFIG_SOC_AM43XX
>> # undef soc_is_am43xx
>> # undef soc_is_am437x
>> -# define soc_is_am43xx() is_am43xx()
>> -# define soc_is_am437x() is_am437x()
>> +# undef soc_is_am438x
>> +# define soc_is_am43xx() of_machine_is_compatible("ti,am43")
>> +# define soc_is_am437x() of_machine_is_compatible("ti,am4372")
>> +# define soc_is_am438x() of_machine_is_compatible("ti,am438x")
>> #endif
>
> Hmm didn't I already comment on this change? I don't want to do it
> for one SoC. Please add the SoC detection the old way for am43xx,
> then do another series that changes all the DT only SoCs to use
> of_machine_is_compatible() after it's been properly tested so now
> regressions are caused for the early init code.
Okay. I misinterpreted your earlier comment. Thanks for clarifying.
I will re-do.
>
> Regards,
>
> Tony
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-08-11 17:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 9:28 [rtc-linux] [PATCH v2 0/6] ARM: AM4372: Enable RTC Keerthy
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 1/6] ARM: dts: AM43XX: Add clk_32k_rtc node Keerthy
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 2/6] rtc: omap: Add external clock enabling support Keerthy
2015-08-11 14:00 ` [rtc-linux] " Alexandre Belloni
2015-08-12 14:27 ` Paul Walmsley
2015-08-12 19:08 ` Keerthy
2015-08-12 20:16 ` Alexandre Belloni
2015-08-13 20:17 ` Paul Walmsley
2015-08-14 4:55 ` Keerthy
2015-08-14 8:29 ` Alexandre Belloni
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs Keerthy
2015-08-11 12:55 ` [rtc-linux] " Tony Lindgren
2015-08-11 17:54 ` Keerthy [this message]
2015-08-12 8:37 ` Tony Lindgren
2015-08-13 6:59 ` Keerthy
2015-08-13 9:04 ` Keerthy
2015-08-13 9:59 ` Tony Lindgren
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 4/6] ARM: dts: am43x-epos-evm: Add the am438 compatible string Keerthy
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 5/6] ARM: AM43XX: HWMOD: Add rtc hwmod Keerthy
2015-08-12 14:39 ` [rtc-linux] " Paul Walmsley
2015-08-13 6:39 ` Tero Kristo
2015-08-10 9:28 ` [rtc-linux] [PATCH v2 6/6] ARM: dts: AM437X-GP-EVM: Enable rtc Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CA36D2.3080509@ti.com \
--to=a0393675@ti.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=rtc-linux@googlegroups.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox