From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com (bear.ext.ti.com. [192.94.94.41]) by gmr-mx.google.com with ESMTPS id g7si149710igr.0.2015.08.13.00.00.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 13 Aug 2015 00:00:16 -0700 (PDT) Message-ID: <55CC406C.3030001@ti.com> Date: Thu, 13 Aug 2015 12:29:56 +0530 From: Keerthy MIME-Version: 1.0 To: Tony Lindgren CC: Keerthy , , , , , , , , , , , , , Subject: [rtc-linux] Re: [PATCH v2 3/6] ARM: AM43xx: Introduce a separate soc_is function for am438x series of SoCs References: <1439198906-31189-1-git-send-email-j-keerthy@ti.com> <1439198906-31189-4-git-send-email-j-keerthy@ti.com> <20150811125515.GN4215@atomide.com> <55CA36D2.3080509@ti.com> <20150812083718.GS4215@atomide.com> In-Reply-To: <20150812083718.GS4215@atomide.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wednesday 12 August 2015 02:07 PM, Tony Lindgren wrote: > * Keerthy [150811 10:57]: >> >> >> On Tuesday 11 August 2015 06:25 PM, Tony Lindgren wrote: >>> * Keerthy [150810 02:31]: >>>> @@ -371,8 +372,10 @@ IS_OMAP_TYPE(3430, 0x3430) >>>> #ifdef CONFIG_SOC_AM43XX >>>> # undef soc_is_am43xx >>>> # undef soc_is_am437x >>>> -# define soc_is_am43xx() is_am43xx() >>>> -# define soc_is_am437x() is_am437x() >>>> +# undef soc_is_am438x >>>> +# define soc_is_am43xx() of_machine_is_compatible("ti,am43") >>>> +# define soc_is_am437x() of_machine_is_compatible("ti,am4372") >>>> +# define soc_is_am438x() of_machine_is_compatible("ti,am438x") >>>> #endif >>> >>> Hmm didn't I already comment on this change? I don't want to do it >>> for one SoC. Please add the SoC detection the old way for am43xx, >>> then do another series that changes all the DT only SoCs to use >>> of_machine_is_compatible() after it's been properly tested so now >>> regressions are caused for the early init code. >> >> Okay. I misinterpreted your earlier comment. Thanks for clarifying. >> I will re-do. > > Actually, can you please do the following patches first while at it: > > 1. Change dra7 SoC detection to intialize soc_name and soc_rev > registers based on the of_machine_is_compatible so we don't > do pointless string comparisons with the current code > > 2. Add am437x detection the same way > > 3. Change all the existing DT only SoCs to do the same (this > can be done in a separate series) > > That should allow us to drop most of the SoC detection code. Alright. I will post only the clock dts patch and the driver patches for now. I will work on 1,2 and 3 in order. Thanks Tony for your feedback. -Keerthy > > Regards, > > Tony > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.