From: Xing Zheng <zhengxing@rock-chips.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v2 9/9] rtc: hym8563: make sure hym8563 can be normal work
Date: Thu, 17 Sep 2015 20:44:38 +0800 [thread overview]
Message-ID: <55FAB5B6.3010605@rock-chips.com> (raw)
In-Reply-To: <20150917123138.GG4287@piout.net>
On 2015=E5=B9=B409=E6=9C=8817=E6=97=A5 20:31, Alexandre Belloni wrote:
> Hi,
>
> On 17/09/2015 at 14:07:47 +0200, Heiko St=C3=BCbner wrote :
>> Am Donnerstag, 17. September 2015, 18:39:28 schrieb Xing Zheng:
>>> The rtc hym8563 maybe failed to register if first startup or rtc
>>> powerdown:
>>> [ 0.988540 ] rtc-hym8563 1-0051: no valid clock/calendar values avai=
lable
>>> [ 0.995642 ] rtc-hym8563 1-0051: rtc core: registered hym8563 as rtc=
0 [
>>> 1.078985 ] rtc-hym8563 1-0051: no valid clock/calendar values availa=
ble [
>>> 1.085698 ] rtc-hym8563 1-0051: hctosys: unable to read the hardware
>>> clock
>>>
>>> We can set initial time for rtc and register it:
>>> [ 0.995678 ] rtc-hym8563 1-0051: rtc core: registered hym8563 as rtc=
0
>>> [ 1.080313 ] rtc-hym8563 1-0051: setting system clock to 2000-01-01
>>> 00:02:00 UTC (946684920)
>> hmm, not setting a false date was actually intentional when I did the dr=
iver.
>>
>> In my mind it is better to shout and keep programs from using wrong valu=
es
>> than to set some arbitary date and let programs silently use this wrong =
value.
>>
> Indeed, I find it worse to set a wrong value instead of returning an
> error. Userspace has to define its policy when reading the time fails.
>
OK, I got it, this patch will be abandoned at next version.
Thanks.
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2015-09-17 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 8:28 [rtc-linux] [PATCH v2 0/9] Build and support rk3036 SoC platform Xing Zheng
2015-09-17 9:59 ` [rtc-linux] " Heiko Stübner
2015-09-17 10:39 ` [rtc-linux] [PATCH v2 9/9] rtc: hym8563: make sure hym8563 can be normal work Xing Zheng
2015-09-17 12:07 ` [rtc-linux] " Heiko Stübner
2015-09-17 12:31 ` Alexandre Belloni
2015-09-17 12:44 ` Xing Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAB5B6.3010605@rock-chips.com \
--to=zhengxing@rock-chips.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox