From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Kukjin Kim <kgene.kim@samsung.com>
Cc: k.kozlowski.k@gmail.com, linux-samsung-soc@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: Pending rtc-s3c patches
Date: Sun, 1 Nov 2015 20:36:51 +0900 [thread overview]
Message-ID: <5635F953.6080702@samsung.com> (raw)
In-Reply-To: <20151028101449.GA13014@piout.net>
W dniu 28.10.2015 o 19:14, Alexandre Belloni pisze:
> Hi,
>
> There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd
> like to get an update and either drop or apply those.
>
> Can someone take a few minutes to review them?
>
> The patches are:
> http://patchwork.ozlabs.org/patch/71318/
This is not needed. The pie_lock (replacing s3c_rtc_pie_lock) protects
set_freq() which:
1. is called only during probe;
2. is accessing different registers than s3c_rtc_setaie().
> http://patchwork.ozlabs.org/patch/99857/
This is good although does not apply cleanly. I rebased, tested and send
the patch.
> http://patchwork.ozlabs.org/patch/101732/
This does not look good. Code is actually used so commit description
does not match current state. I think you can ignore it.
Best regards,
Krzysztof
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2015-11-01 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 10:14 [rtc-linux] Pending rtc-s3c patches Alexandre Belloni
2015-10-28 13:04 ` [rtc-linux] " Krzysztof Kozlowski
2015-11-01 11:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5635F953.6080702@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox