From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by gmr-mx.google.com with ESMTPS id jj4si12379951pac.2.2016.01.12.03.31.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2016 03:31:16 -0800 (PST) Message-ID: <5694E19A.2050107@nvidia.com> Date: Tue, 12 Jan 2016 16:50:58 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Julia Lawall CC: , , , , , , , , , , , , , , , , , , Subject: [rtc-linux] Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > Please take the patch only if it's a positive warning. Thanks! > > rtc-max77xxx.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/rtc/rtc-max77xxx.c > +++ b/drivers/rtc/rtc-max77xxx.c > @@ -480,6 +480,7 @@ static const struct platform_device_id m > { .name = "max77xxx-rtc", }, > { .name = "max77620-rtc", }, > { .name = "max20024-rtc", }, > + {}, > }; > > static struct platform_driver max77xxx_rtc_driver = { -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.