From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id jg4si631542pac.2.2016.01.22.03.50.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2016 03:50:09 -0800 (PST) Message-ID: <56A214EB.30905@nvidia.com> Date: Fri, 22 Jan 2016 17:09:23 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Krzysztof Kozlowski , , , , , , , , , , , CC: , , , , , , , , Chaitanya Bandi , Mallikarjun Kasoju Subject: [rtc-linux] Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024 References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-3-git-send-email-ldewangan@nvidia.com> <569F199D.9020207@samsung.com> In-Reply-To: <569F199D.9020207@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Thanks Krzysztof for review. Hi Lee, Are you taking the patches from your tree? Or will go in individual subsystem? Thanks, Laxman On Wednesday 20 January 2016 10:52 AM, Krzysztof Kozlowski wrote: > On 19.01.2016 19:19, Laxman Dewangan wrote: >> MAX77620/MAX20024 are Power Management IC from the MAXIM. >> It supports RTC, multiple GPIOs, multiple DCDC and LDOs, >> watchdog, clock etc. >> >> Add MFD drier to provides common support for accessing the >> device; additional drivers is developed on respected subsystem >> in order to use the functionality of the device. >> >> Signed-off-by: Laxman Dewangan >> Signed-off-by: Chaitanya Bandi >> Signed-off-by: Mallikarjun Kasoju >> --- >> Changes from V1: >> - Code cleanups per review from V1. >> - Move register acccess APIs from header to c file. >> - Remove some of non required variable, remove duplication in error message >> and simplify some of function implementation. >> - Register RTC driver such that it can get the regmap handle form parent device >> >> Changes from V2: >> - Run coccicheck and checkpatch in strict mode for the alignment. >> - Drop RTC driver and its i2c client registration. >> >> Changes from V3: >> - Change all sys initcall to module driver. >> - change the max77620_read argument to unisgned int from u8. >> >> drivers/mfd/Kconfig | 15 + >> drivers/mfd/Makefile | 1 + >> drivers/mfd/max77620.c | 871 +++++++++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/max77620.h | 404 ++++++++++++++++++++ >> 4 files changed, 1291 insertions(+) >> create mode 100644 drivers/mfd/max77620.c >> create mode 100644 include/linux/mfd/max77620.h >> > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.