From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rtc-linux+bncBDKZNNNLXAHBBKH2SW3AKGQEIL4KI4I@googlegroups.com>
Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11])
        by gmr-mx.google.com with ESMTPS id 79si789378pft.0.2016.02.18.00.13.27
        for <rtc-linux@googlegroups.com>
        (version=TLS1 cipher=AES128-SHA bits=128/128);
        Thu, 18 Feb 2016 00:13:28 -0800 (PST)
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
 by mailout1.w1.samsung.com
 (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May  5 2014))
 with ESMTP id <0O2Q00ICOHIB8J10@mailout1.w1.samsung.com> for
 rtc-linux@googlegroups.com; Thu, 18 Feb 2016 08:13:23 +0000 (GMT)
Subject: [rtc-linux] Re: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings
To: Valentin Rothberg <valentin.rothberg@posteo.net>, ldewangan@nvidia.com
References: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net>
Cc: kbuild-all@01.org, alexandre.belloni@free-electrons.com,
 javier@osg.samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it,
 linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
 kbuild test robot <fengguang.wu@intel.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <56C57D1E.805@samsung.com>
Date: Thu, 18 Feb 2016 17:13:18 +0900
MIME-version: 1.0
In-reply-to: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net>
Content-type: text/plain; charset=UTF-8
Reply-To: rtc-linux@googlegroups.com
List-ID: <rtc-linux.googlegroups.com>
List-Post: <https://groups.google.com/group/rtc-linux/post>, <mailto:rtc-linux@googlegroups.com>
List-Help: <https://groups.google.com/support/>, <mailto:rtc-linux+help@googlegroups.com>
List-Archive: <https://groups.google.com/group/rtc-linux
Sender: rtc-linux@googlegroups.com
List-Subscribe: <https://groups.google.com/group/rtc-linux/subscribe>, <mailto:rtc-linux+subscribe@googlegroups.com>
List-Unsubscribe: <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,
 <https://groups.google.com/group/rtc-linux/subscribe>

On 18.02.2016 17:06, Valentin Rothberg wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> 
>  Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
>  threaded IRQs without a primary handler need to be requested with
>  IRQF_ONESHOT, otherwise the request will fail.
> 
>  So pass the IRQF_ONESHOT flag in this case.
> 
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> 
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
> ---
>  drivers/rtc/rtc-max77686.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Nack, because:
1. AFAIR this is a false positive.
2. Was it tested? Was it reproduced? Was the bug actually spotted or
just coccicheck pointed this and you assumed that "request will fail"?

Coccicheck is a great tool... but not necessarily for pointing run-time
bugs.

Best regards,
Krzysztof



-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.