From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id ui7si3614020pab.0.2016.03.14.14.07.43 for ; Mon, 14 Mar 2016 14:07:43 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral To: Joe Perches , linux-kernel@vger.kernel.org References: <1457987157-1177-1-git-send-email-javier@osg.samsung.com> <1457987453.11972.133.camel@perches.com> Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56E72818.8050407@osg.samsung.com> Date: Mon, 14 Mar 2016 18:07:36 -0300 MIME-Version: 1.0 In-Reply-To: <1457987453.11972.133.camel@perches.com> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Joe, On 03/14/2016 05:30 PM, Joe Perches wrote: > On Mon, 2016-03-14 at 17:25 -0300, Javier Martinez Canillas wrote: >> The clock and source clock looked up by the driver may not be available >> just because the clock controller driver was not probed yet so printing >> an error in this case is not correct and only adds confusion to users. >> >> However, knowing that a driver's probe was deferred may be useful so it >> can be printed as debug information. > > Hello again Javier: >> + dev_dbg(&pdev->dev, "probe deferred due missing rtc clk\n"); > > Again, intelligible English would not use "due" > but would use "due to" or "because of". > Ok, I'll post another version then. I hope the third time's the charm... Alexandre, do you have any other comments before I re-spin this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.