From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mailapp01.imgtec.com (mailapp01.imgtec.com. [195.59.15.196]) by gmr-mx.google.com with ESMTP id c7si279319wmf.2.2016.03.17.06.33.06 for ; Thu, 17 Mar 2016 06:33:06 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree To: Alexandre Belloni , Paul Cercueil References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-3-git-send-email-paul@crapouillou.net> <20160317120804.GD3362@piout.net> CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , , , , From: Harvey Hunt Message-ID: <56EAB210.70900@imgtec.com> Date: Thu, 17 Mar 2016 13:33:04 +0000 MIME-Version: 1.0 In-Reply-To: <20160317120804.GD3362@piout.net> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Alexandre, On 17/03/16 12:08, Alexandre Belloni wrote: > On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote : >> Signed-off-by: Paul Cercueil >> --- >> drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c >> index 47617bd..3914b1c 100644 >> --- a/drivers/rtc/rtc-jz4740.c >> +++ b/drivers/rtc/rtc-jz4740.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev) >> } >> EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff); >> >> +static const struct of_device_id jz4740_rtc_of_match[] = { >> + { .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 }, >> + { .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 }, > > ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt, > you have to add it there before using it. Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7 ("devicetree/bindings: add Ingenic Semiconductor vendor prefix"). Thanks, Harvey -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.