[rtc-linux] Re: [PATCH] rtc: omap: Support ext_wakeup configuration

[Grygorii Strashko <grygorii.strashko@ti.com>]

Hi Tony,

On 04/05/2016 01:40 AM, Tony Lindgren wrote:
> Hi,
> 
> * Marcin Niestroj <m.niestroj@grinn-global.com> [160404 08:57]:
>> Support configuration of ext_wakeup sources. This patch makes it
>> possible to enable ext_wakeup and set it's polarity, depending on board
>> configuration. AM335x's dedicated PMIC (tps65217) uses ext_wakeup to
>> notify about power-button presses. Handling power-button presses enables
>> to recover from RTC-only power states correctly.
> 
> I suggest you just set this pin up as a minimal gpiochip. That way
> we can use the standard binding :) And if we get lucky, this pin can
> also trigger during runtime.
> 

Following my comments on v2 of this patch I propose to rollback to
this version of the patch.

It seems doesn't fit in gpiochip, it's more likely irqchip, but since
rtc can't generate IRQ there are nor reasons for these genetic
experiments and RTC's specific bindings looks more suitable, at least for me.


-- 
regards,
-grygorii

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.