From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTPS id i135si336814pfe.0.2016.07.05.01.47.25 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 05 Jul 2016 01:47:25 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9U00XY032ZR8D0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Tue, 05 Jul 2016 17:47:23 +0900 (KST) Message-id: <577B73FE.1020509@samsung.com> Date: Tue, 05 Jul 2016 14:16:54 +0530 From: Alim Akhtar MIME-version: 1.0 To: Krzysztof Kozlowski , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Cc: alexandre.belloni@free-electrons.com, javier@osg.samsung.com, pankaj.dubey@samsung.com Subject: [rtc-linux] Re: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock References: <1467630195-6929-1-git-send-email-alim.akhtar@samsung.com> <577B5F28.1010905@samsung.com> In-reply-to: <577B5F28.1010905@samsung.com> Content-type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Krzsztof, On 07/05/2016 12:48 PM, Krzysztof Kozlowski wrote: > On 07/04/2016 01:03 PM, Alim Akhtar wrote: >> At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc >> clock already disabled, which looks extra and unnecessary call. >> Lets clean it up. > > Does not look right. Till that place, the clocks are enabled. Then > s3c_rtc_setaie() is called which expects that clocks are disabled... > otherwise counters get mixed. > The clock is always disabled when it reach s3c_rtc_setfreq() in probe(), because s3c_rtc_gettime() will always disable the clock. As far as s3c_rtc_setaie() is concern, it enables clock while entering and disables it while leaving the function. And in s3c_rtc_{enable,disable}_clk() there is check info->clk_disabled flag which will make sure clock balancing. > So overall this looks like wrong approach unless I am missing something? > > Best regards, > Krzysztof > >> >> Signed-off-by: Alim Akhtar >> --- >> drivers/rtc/rtc-s3c.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c >> index d01ad7e..b083840 100644 >> --- a/drivers/rtc/rtc-s3c.c >> +++ b/drivers/rtc/rtc-s3c.c >> @@ -577,8 +577,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) >> >> s3c_rtc_setfreq(info, 1); >> >> - s3c_rtc_disable_clk(info); >> - >> return 0; >> >> err_nortc: > > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.