From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19302C6FD1D for ; Tue, 4 Apr 2023 13:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235016AbjDDNLF (ORCPT ); Tue, 4 Apr 2023 09:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbjDDNLB (ORCPT ); Tue, 4 Apr 2023 09:11:01 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ECA4358B for ; Tue, 4 Apr 2023 06:10:56 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id ew6so130317911edb.7 for ; Tue, 04 Apr 2023 06:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680613856; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fqtoEDZVWkpxcyzUs7xGDK15f83XMUNAY3m/O6ttw+s=; b=h+Dkbi6kOstMI39IA7cvSaywyJX4Ycw3uQ2u6jjtLZTs8F/imiXll66ajpcoXGbhEM lGn5DPPGBpyNQBhkv6IltksGxH99RDtaLUyKm4d+hMiDeQuhr0QzAJUcZ3JN3ASKhtXy CV6rUEJ1GsCWxcDquhpOpRx0kHERW447ObIZDbM69mQM5Yj4L2VZsgFcFI+hQtXGXBre CjIUvJn818WyklraPGkuSgLG97PedNk7tMr7ufDFUFzDy+Au6LvHF91rGhZquZ5B4myF MdGvYUVNSzTV+j5Q89sk950JpkemyKlPaZougK/2JqzoDCQKQzZptLwrBmA2Zq3g7oIz rrmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680613856; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fqtoEDZVWkpxcyzUs7xGDK15f83XMUNAY3m/O6ttw+s=; b=IZ2TTPyGriCTXSrHmRJ33MyIEt5jGy4pc4g1NInBjSK9B5uj5Z8omjBi+talgDOcH4 vnE4sZjfLovNMl0paxlY32Lf+JjBD5J1bkwg/OOpwa1lr0UdpbcIK0RF58HJwfL6uWgi 3FlYm5Y2EFuuWnUENYzPZPzBf1bIDDFUJ/gF5AjD8Mhj40DU0p3VUBGjca6DHgiUp3lK y7pe6PY8ELKJwkFJVLZB5xKcVgZzWrh3v9TaX9bhtrgVUY01CaAFzBhdK4cBXGE7UQ2r rtTk58bL39jSWAfk7/HoeXrf8sp7ybk0/kM3Walyvl10yInDa6Kgr9zXNXCdkhi5Kk76 B3Rg== X-Gm-Message-State: AAQBX9d3J+SAd/JH19XLsLzIYeYoQ/d9FA7MPeuDF8MM9TRO5AIvb6lu KtrPjXNta3AiUCzsZth0a0vdKQ== X-Google-Smtp-Source: AKy350bvVu02KBDj6r/vYN8VfjwRMyssZiem2eDoz/ZAF9OvotcITs/vY4jFbqhN0TVVTroBZlyCfw== X-Received: by 2002:a17:906:3553:b0:944:6d88:206 with SMTP id s19-20020a170906355300b009446d880206mr2250852eja.71.1680613855935; Tue, 04 Apr 2023 06:10:55 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7467:56f4:40b7:cba8? ([2a02:810d:15c0:828:7467:56f4:40b7:cba8]) by smtp.gmail.com with ESMTPSA id r19-20020a50c013000000b004fd29e87535sm5870813edb.14.2023.04.04.06.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:10:55 -0700 (PDT) Message-ID: <5c4a2a12-9ae7-fb26-ed48-4fb4dfd792f3@linaro.org> Date: Tue, 4 Apr 2023 15:10:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 1/2] drivers: rtc: add max313xx series rtc driver Content-Language: en-US To: Ibrahim Tilki , a.zummo@towertech.it, alexandre.belloni@bootlin.com, jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, Zeynep Arslanbenzer References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-2-Ibrahim.Tilki@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20230403154342.3108-2-Ibrahim.Tilki@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 03/04/2023 17:43, Ibrahim Tilki wrote: > Adding support for Analog Devices MAX313XX series RTCs. > > Signed-off-by: Ibrahim Tilki > Signed-off-by: Zeynep Arslanbenzer (...) > + > +static int max313xx_clkout_register(struct device *dev) > +{ > + struct max313xx *rtc = dev_get_drvdata(dev); > + int ret; > + > + if (!device_property_present(dev, "#clock-cells")) Why would it be not present? Best regards, Krzysztof