From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8144CC77B61 for ; Mon, 24 Apr 2023 09:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbjDXJsW (ORCPT ); Mon, 24 Apr 2023 05:48:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231503AbjDXJsK (ORCPT ); Mon, 24 Apr 2023 05:48:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6406A40C6; Mon, 24 Apr 2023 02:47:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EDA861F8F; Mon, 24 Apr 2023 09:47:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 213D9C433D2; Mon, 24 Apr 2023 09:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682329658; bh=FoOMzZ9W2LOp0CpmrKDEkp3PtIM99Y8iatERnmHe6IY=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=jJcFG2URKWfqioGUKJbzEevLZtmaIJr7DjJQ1d6nlyv9LCxU7XrBNs7c0tEyt28hq 33LW3Ia69ZD6+NycB98lyZKLwwhj/1GBJlsIP211oSiCdgoZW/Zk7HxwDVQ6svaRqK xudpHB3vz0DMwJGiiftfAb5G1sYawukLKUOhfsz5MKWhUpH3zGbCP0exrHMJg9OtbF wlzkNyfZGhgkGEXOYOoE2ro+PgjZsY0jawZNwwQPz604+pzaBZNvbzGr6XnCpaDYMC zJDJVBMwrMjLZ4F0ykq4OmQRw3ozLS4oaHXWeO+WyVzJ3KeGj5nx5EApoGQrM9J8s9 6TCY1h+JfdPNQ== Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 09C9327C0054; Mon, 24 Apr 2023 05:47:36 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 24 Apr 2023 05:47:37 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedutddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusehkvghrnhgvlhdrohhrgheqnecuggftrf grthhtvghrnhepvdeviefgtedugeevieelvdfgveeuvdfgteegfeeiieejjeffgeeghedu gedtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduvdekhedujedt vdegqddvkeejtddtvdeigedqrghrnhgupeepkhgvrhhnvghlrdhorhhgsegrrhhnuggsrd guvg X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8BFD5B60086; Mon, 24 Apr 2023 05:47:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6 Mime-Version: 1.0 Message-Id: <60b87f6c-29ee-4ed8-a78d-3ef632aa0655@app.fastmail.com> In-Reply-To: <20230424123522.18302-30-nikita.shubin@maquefel.me> References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230424123522.18302-30-nikita.shubin@maquefel.me> Date: Mon, 24 Apr 2023 11:47:15 +0200 From: "Arnd Bergmann" To: "Nikita Shubin" Cc: "Linus Walleij" , "Alexander Sverdlin" , "Alessandro Zummo" , "Alexandre Belloni" , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 29/43] rtc: m48t86: add DT support for m48t86 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Mon, Apr 24, 2023, at 14:34, Nikita Shubin wrote: > - get regs from device tree > > Signed-off-by: Nikita Shubin Acked-by: Arnd Bergmann > > +#ifdef CONFIG_OF > +static const struct of_device_id m48t86_rtc_of_ids[] = { > + { .compatible = "dallas,rtc-m48t86" }, > + { /* end of table */ }, > +}; > +MODULE_DEVICE_TABLE(of, m48t86_rtc_of_ids); > +#endif > + > static struct platform_driver m48t86_rtc_platform_driver = { > .driver = { > .name = "rtc-m48t86", > + .of_match_table = of_match_ptr(m48t86_rtc_of_ids), > }, > .probe = m48t86_rtc_probe, If you end up doing another revision, I'd suggest you drop the of_match_ptr() and the #ifdef: there is no point in saving a few bytes of space for non-DT kernel builds if both the machines that use this device always rquire CONFIG_OF to be enabled. Arnd