From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, s32@nxp.com, imx@lists.linux.dev,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>,
Eric Chanudet <echanude@redhat.com>,
Larisa Grigore <larisa.grigore@nxp.com>
Subject: Re: [PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property
Date: Thu, 10 Apr 2025 17:51:06 +0300 [thread overview]
Message-ID: <652aa23b-ba12-42c3-94b7-8d0bbe548aec@oss.nxp.com> (raw)
In-Reply-To: <Z/fZww9TDLhm66O3@lizhi-Precision-Tower-5810>
On 4/10/2025 5:46 PM, Frank Li wrote:
> On Thu, Apr 10, 2025 at 11:25:47AM +0300, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> In case the RTC is not linked to any battery, the oscillator will
>> be stopped at startup, triggering a SW reset command for the PCF85063 RTC.
>> For this setup, introduce 'no-battery' property which can be used to
>> manually start the oscillator.
>>
>> Co-developed-by: Larisa Grigore <larisa.grigore@nxp.com>
>> Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>> Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> index 2f892f8640d1..b342eb13fb2e 100644
>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> @@ -36,6 +36,11 @@ properties:
>> enum: [7000, 12500]
>> default: 7000
>>
>> + no-battery:
>> + description: Used in case the RTC is not linked to any battery so the
>> + oscillator is stopped at startup.
>> + type: boolean
>
> Can you use optional regulator such as, vbat-supply?
>
> Frank
>
Hello Frank,
Please disregard this patchset, as stated in the next patch review [1]
[1]
https://lore.kernel.org/all/e64083ee-3374-4bdf-92a3-ce91e1402b13@oss.nxp.com/
Regards,
Ciprian
>> +
>> clock:
>> $ref: /schemas/clock/fixed-clock.yaml
>> description:
>> --
>> 2.45.2
>>
next prev parent reply other threads:[~2025-04-10 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 8:25 [PATCH 0/2] enable PCF85063 RTC support for S32G274A-RDB2 and S32G399A-RDB3 boards Ciprian Costea
2025-04-10 8:25 ` [PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property Ciprian Costea
2025-04-10 14:46 ` Frank Li
2025-04-10 14:51 ` Ciprian Marian Costea [this message]
2025-04-10 8:25 ` [PATCH 2/2] rtc: pcf85063: handle stopped oscillator at startup Ciprian Costea
2025-04-10 9:17 ` Alexandre Belloni
2025-04-10 12:56 ` Ciprian Marian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652aa23b-ba12-42c3-94b7-8d0bbe548aec@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=Frank.li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=echanude@redhat.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox