Re: [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE()

[Matthias Brugger <mbrugger@suse.com>]

On 04/07/2026 14:20, Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
> 
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>

Reviewed-by: Matthias Brugger <mbrugger@suse.com>

> ---
>   drivers/rtc/rtc-s32g.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/rtc/rtc-s32g.c b/drivers/rtc/rtc-s32g.c
> index 3a0818e972eb..86716192d10f 100644
> --- a/drivers/rtc/rtc-s32g.c
> +++ b/drivers/rtc/rtc-s32g.c
> @@ -366,6 +366,7 @@ static const struct of_device_id rtc_dt_ids[] = {
>   	{ .compatible = "nxp,s32g2-rtc", .data = &rtc_s32g2_data },
>   	{ /* sentinel */ },
>   };
> +MODULE_DEVICE_TABLE(of, rtc_dt_ids);
>   
>   static DEFINE_SIMPLE_DEV_PM_OPS(s32g_rtc_pm_ops,
>   			 s32g_rtc_suspend, s32g_rtc_resume);
>