From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B05C77B62 for ; Tue, 4 Apr 2023 13:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbjDDNCV (ORCPT ); Tue, 4 Apr 2023 09:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234372AbjDDNCU (ORCPT ); Tue, 4 Apr 2023 09:02:20 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC5D1BC7 for ; Tue, 4 Apr 2023 06:02:19 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r11so130323059edd.5 for ; Tue, 04 Apr 2023 06:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680613337; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=80YBPi+85zCnOkMuZy/EOCJgSFeaKJCfBUB0QXoMJG0=; b=n9c4JUKx+rSAWG3kH+jFpCPCju35S2p0ig5Szc/q2VRDyUfttMRDmgoXNqSX8dC5Um QCkapdOErvevGkUPysYDk1W/A582aXWjKE5a5BNq7Eh9MEdtH8ysVCQnt+4SV+wRgSiQ iAB6iQzhfbcU5+SR4y/bPpSCiOrT5g+P9DZRHMgQO/Q2PArngIWvPdf69/26Uqk9uRnm bVcv2j6SNqTEZG5u1xKS9sVWybQADCF5W9LyjwAIPY17BlUdLfBFkK0Ho+1d+86dIBeQ ggTuSsovpCQ3aGOA2GfrPdm+sa7GCq5G4cxZLl2boJJiRiIxkhYUM4YPEsEaCZSIwZ7y ddiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680613337; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=80YBPi+85zCnOkMuZy/EOCJgSFeaKJCfBUB0QXoMJG0=; b=tL1DdIv+O5KOP0I3GyDkmz/mBw6u1thq8oaPL6Z+qfPOPFeW9zZCdiXY5D3ypXb+l2 SkGjZPq630BoA9uH4Z2hBM32aCjmubEkj0vyKK5jdpm9shzDDJR5tUWRAojX1A1mtvvo i6F1Os9pUA3a6DSvALIW0M809MXazs1E5SQUrUHvZtDUQOSWIonMVxd41Xsl2tc0Ulup szPedvBu4FNyh1TaiNi1N6GAWkHb5cgwdaVijIo0haRReGOMflUovnJNIkZlwCjHzcU2 g2xqQyfSAl/IGDzAo3F1ku4stcu7OrPHUqdS8wfuh8gFHOwY9AhKPPNGwmcDFLbc0g5D GcFA== X-Gm-Message-State: AAQBX9fX6Rn3RHQxFxz8JR5afPq2Kx9fMXiUoNnChW04bj9Wk+Qx69Hp 3k2YvFGtPaBWSX5y4U+xhlEARw== X-Google-Smtp-Source: AKy350aF8oPMiNgn4tk1wpZPkLE/N6LCtJYbRyyIQqV6ip9JZ5rFaqVYWqODG9QkmJpKUvt6S7C6AA== X-Received: by 2002:a17:906:27d4:b0:930:3840:1c4d with SMTP id k20-20020a17090627d400b0093038401c4dmr2207998ejc.32.1680613337609; Tue, 04 Apr 2023 06:02:17 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7467:56f4:40b7:cba8? ([2a02:810d:15c0:828:7467:56f4:40b7:cba8]) by smtp.gmail.com with ESMTPSA id e27-20020a50d4db000000b004fadc041e13sm5884140edj.42.2023.04.04.06.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:02:17 -0700 (PDT) Message-ID: <68bc0c88-541d-269d-58d2-67dbe6d44b7e@linaro.org> Date: Tue, 4 Apr 2023 15:02:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs To: Alexandre Belloni , "Tilki, Ibrahim" Cc: "a.zummo@towertech.it" , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "Arslanbenzer, Zeynep" References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com> <20230403154342.3108-3-Ibrahim.Tilki@analog.com> <202304040710049c9cc01a@mail.local> <1efdb870-cac2-f6ed-72b5-d0550dbb5257@linaro.org> <202304041226162e231e78@mail.local> <2023040412291166c04438@mail.local> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <2023040412291166c04438@mail.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 04/04/2023 14:29, Alexandre Belloni wrote: > On 04/04/2023 14:26:18+0200, Alexandre Belloni wrote: >> On 04/04/2023 10:35:53+0000, Tilki, Ibrahim wrote: >>>>>>>> + aux-voltage-chargeable: >>>>>>>> + enum: [0, 1, 2] >>>>>>>> + description: | >>>>>>>> + Enables trickle charger. >>>>>>>> + 0: Charger is disabled (default) >>>>>>>> + 1: Charger is enabled >>>>>>>> + 2: Charger is enabled with a diode >>>>>>> >>>>>>> 2 is not an allowed value. I asked to drop this property. It is coming >>>>>>> from rtc.yaml. I also do not understand "with a diode". So otherwise it >>>>>>> is charging with, I don't know, FET? >>>>>> >>>>>> No, what is not explained here (and maybe not unsterstood by the >>>>>> submitter) is that the RTC has an extra diode so, charging will always >>>>>> enable a diode, select a resistor and then have or not an extra diode. >>>>>> Figure2 of the MAX31329 datasheet is great. >>>>>> >>>>> >>>>> That is exactly why I had "adi,trickle-diode-enable" property in previous patch. >>>>> So if I can't have "adi,trickle-diode-enable" and can't add an additional value >>>>> to "aux-voltage-chargeable", I am not sure how to add support for the extra >>>>> diode at this point. >>>> >>>> Ask the person who asked you to remove adi,trickle-diode-enable... >>> >>> That was the purpose. >>> >> >> If the earlier submission was clearer my answer would have been >> different but note how I had to dig up the datasheet to understand there >> were two diodes. All the trickle chargers have a schottky diode so >> "adi,trickle-diode-enable" nor the commit log were explicit about the >> second diode (which is a regular diode). >> >> aux-voltage-chargeable is enabling a diode on all the existing RTC >> drivers so instead of trying to make me look like the bad guy you should >> rather thank for taking the time trying to get better DT bindings. >> > > BTW, Krzysztof, you should focus more on how v5 of the driver is still > abusing the #clock-cells property to do pinmuxing after I repeatedly > explain to not do that. Uh, I assumed #clock-cells in the binding is for its purpose - clocks. I am rarely verifying driver implementation. Best regards, Krzysztof