From: Michal Simek <michal.simek@amd.com>
To: Tomas Melin <tomas.melin@vaisala.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 1/6] rtc: zynqmp: declare dependency on arch
Date: Thu, 22 Jan 2026 13:38:22 +0100 [thread overview]
Message-ID: <7786b3e3-15bd-44ee-be05-3ee5aa52743e@amd.com> (raw)
In-Reply-To: <d63d7f6f-0ff3-4f2d-8326-96b29d7fe57c@vaisala.com>
On 1/22/26 13:25, Tomas Melin wrote:
> Hi,
>
> On 21/01/2026 14:16, Michal Simek wrote:
>>
>>
>> On 1/19/26 10:51, Tomas Melin wrote:
>>> Driver is compatible with RTC controller found on zynqmp.
>>> Configure dependency to enable building only when zynqmp architecture
>>> is enabled.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
>>> ---
>>> drivers/rtc/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>>> index 2933c41c77c88e60df721fe65b9c8afb995ae51e..46b497524cbfb5d0c1662dcaddbb6d28b4ae2abe 100644
>>> --- a/drivers/rtc/Kconfig
>>> +++ b/drivers/rtc/Kconfig
>>> @@ -1376,7 +1376,7 @@ config RTC_DRV_OPTEE
>>>
>>> config RTC_DRV_ZYNQMP
>>> tristate "Xilinx Zynq Ultrascale+ MPSoC RTC"
>>> - depends on OF && HAS_IOMEM
>>> + depends on OF && HAS_IOMEM && ARCH_ZYNQMP
>>
>>
>> arm-linux-gnueabi-ld: drivers/rtc/rtc-zynqmp.o: in function
>> `xlnx_rtc_read_offset':
>> >> rtc-zynqmp.c:(.text.xlnx_rtc_read_offset+0xd0): undefined reference to
>> `__aeabi_ldivmod'
>>
>> You should use macros like div_u64() to fix it instead of have driver enabled
>> only for ZynqMP.
> I can do it that way if you prefer such approach.
Definitely because this driver could be called from different architectures.
RISC-V or x86.
Thanks,
Michal
next prev parent reply other threads:[~2026-01-22 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 9:51 [PATCH v3 0/6] rtc: zynqmp: fixes for read and set offset Tomas Melin
2026-01-19 9:51 ` [PATCH v3 1/6] rtc: zynqmp: declare dependency on arch Tomas Melin
2026-01-21 12:11 ` Michal Simek
2026-01-21 12:16 ` Michal Simek
2026-01-22 12:25 ` Tomas Melin
2026-01-22 12:38 ` Michal Simek [this message]
2026-01-19 9:51 ` [PATCH v3 2/6] rtc: zynqmp: correct frequency value Tomas Melin
2026-01-19 9:51 ` [PATCH v3 3/6] rtc: zynqmp: check calibration max value Tomas Melin
2026-01-19 9:51 ` [PATCH v3 4/6] rtc: zynqmp: rework read_offset Tomas Melin
2026-01-19 9:51 ` [PATCH v3 5/6] rtc: zynqmp: rework set_offset Tomas Melin
2026-01-19 9:51 ` [PATCH v3 6/6] rtc: zynqmp: use dynamic max and min offset ranges Tomas Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7786b3e3-15bd-44ee-be05-3ee5aa52743e@amd.com \
--to=michal.simek@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox