From: Guenter Roeck <linux@roeck-us.net>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 2/2] drivers: rtc: max31335: initial commit
Date: Tue, 31 Oct 2023 06:58:48 -0700 [thread overview]
Message-ID: <7cc209b6-c762-4cd2-bbac-bc6b0cc36166@roeck-us.net> (raw)
In-Reply-To: <CY4PR03MB339979DBB7ADBFC3872156019BA0A@CY4PR03MB3399.namprd03.prod.outlook.com>
On 10/31/23 04:23, Miclaus, Antoniu wrote:
[ ... ]
>>> + if (status != MAX31335_STATUS1_DEFAULT)
>>> + dev_err_probe(&client->dev, -EINVAL,
>>> + "Unable to read from device.\n");
>>> +
>>
>> That is misleading. The device returned an unexpected status.
>> I don't know if this really reflects a problem, but it is not
>> "Unable to read from device".
>>
>
> Since the device lacks an ID register, I found this as a suitable
> replacement for checking that the communication with the
> device actually works before the probe function finishes
> successfully.
>
But the register read was successful. Also, why would you want to not
instantiate the driver if the chip runs on VBAT, if the oscillator
is running, if VBAT is low, or if some interrupt is pending for
some reason ?
Guenter
next prev parent reply other threads:[~2023-10-31 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:50 [PATCH 0/2] Add support for RTC MAX31335 Antoniu Miclaus
2023-10-30 11:50 ` [PATCH 1/2] dt-bindings: rtc: max31335: add max31335 bindings Antoniu Miclaus
2023-10-30 17:24 ` Krzysztof Kozlowski
2023-10-31 9:36 ` Miclaus, Antoniu
2023-10-31 10:29 ` Miclaus, Antoniu
2023-10-31 13:53 ` Krzysztof Kozlowski
2023-10-31 14:44 ` Miclaus, Antoniu
2023-10-31 12:06 ` Rob Herring
2023-10-30 11:50 ` [PATCH 2/2] drivers: rtc: max31335: initial commit Antoniu Miclaus
2023-10-30 17:28 ` Krzysztof Kozlowski
2023-10-30 18:11 ` Guenter Roeck
2023-10-31 11:23 ` Miclaus, Antoniu
2023-10-31 13:54 ` Alexandre Belloni
2023-10-31 14:43 ` Miclaus, Antoniu
2023-10-31 13:58 ` Guenter Roeck [this message]
2023-10-31 11:36 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc209b6-c762-4cd2-bbac-bc6b0cc36166@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Antoniu.Miclaus@analog.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox