From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE71371888; Mon, 1 Jun 2026 11:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314261; cv=none; b=RbVzfdFh0FxgnruIkoFM0YP5F1TlhlToGg12sHECaTcUX21tm2kSnp3YUSzuZ4bIk/yfsksIsOJ9pjnJ2MIcOuMepCArFKZ5ZlOniP+daYU8luQKkkO+i+CZ7m0Fg+YLlYVvnv3TUg2ZFBAmCPvfh9gLaPBeOqr7J5szrhWW5tQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780314261; c=relaxed/simple; bh=Mc7HO4pv5VSTx3/AHqd1sbM/NO8LJj93nB/wxin7H14=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ir0AvfM4usDm7w05RKL7QCwwg2VZrbSotaqhZiINHJHEiMNbYVIlarrCZEz/vuoVFottvq5EVpPVKy5qxWAR/uECRljyxSA3NAIpCUTHgoA5/gQehsXJ30lj/7AkF8dQVMCVMXP4zT3J9cn+qGWGDnnz6exgFTFahMOOJ1B3VlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pf46fETA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pf46fETA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C49701F00893; Mon, 1 Jun 2026 11:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780314260; bh=oDouDsrX2tMApB09VtpLdRio+XtVvmO2XBI27bkSnzk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Pf46fETAs9+wyR+n6TriqzKq6rL3gBF0jbi8YKwh94BgXGRCXWTymY0Q6YD1X0wPj /mYTH4/a2M8a20BfIzf8t7IRueT43BpeCjfiDgLpKfsxa0MVfedS+CSboD827QXRTG BMdXEP1u9iKnTMcCMg8dVetMQF4tazc8zagTayeHB6iz7pMf1b5v/UvQAnMQxgLcpr OO1AnLouRZsLSVLtcnFdry06z+dIe8Jozw5UJHYHN7zjTb5PfkKMf9n1A3g4pAbOBC vwYmDpR9w9MGBSLWWXp5HWj5wJvx5g+4P9Nrz5M+hBf0RA+iHqokoI5lDsWj4CpCaA REOFBjErH6HAA== Message-ID: <7fb5412f-cdde-4cd6-bc38-aad91903ee36@kernel.org> Date: Mon, 1 Jun 2026 13:44:12 +0200 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] dt-bindings: clock: via,vt8500: Convert to DT Schema To: Uday Kiran Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260524151110.21277-1-challauday369@gmail.com> <20260530-academic-aspiring-sawfly-7dcfab@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 31/05/2026 18:49, Uday Kiran wrote: >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: VIA/Wondermedia VT8500 Clock Controller >> >> How PMC is a clock controller? Really? > > No Krzysztof, actually that was a wrong direction in v4. > >>> + >>> +maintainers: >>> + - Michael Turquette >>> + - Stephen Boyd >> >> >> Subsystem maintainers do not care about PMC. This can be platform >> maintainer. > > I agree with you. I changed maintainers accordingly. > >>> + >>> +description: >>> + Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx >>> + series SoCs. >>> + >>> +select: >>> + properties: >>> + compatible: >>> + const: via,vt8500-pmc >>> + >>> + required: >>> + - compatible >> >> Why do you have select? >> >> I don't understand your changes. This was not at v2 and I did not ask to >> change that. > > The select: block with via,vt8500-pmc and the clocks: type: object were > mistakenly added to via,vt8500-clock.yaml in v4 — leftover confusion from > trying to handle the PMC node's clock container in the same schema. In v5 these > are removed from the clock schema entirely. The PMC binding is now a separate > patch (via,vt8500-pmc.yaml) which is the right place for the clock container > node description. > >>> + >>> +properties: >>> + compatible: >>> + const: via,vt8500-pmc >> >> >> So via,vt8500-clock.yaml or pmc? Why aren't you removing the pmc file? >> Why is this located at clocks? > > In the next revision, this patch is scope only to the clock provider bindings > (via,vt8500-device-clock, via,vt8500-pll-clock, wm,*-pll-clock). It no longer > models PMC/top-level node properties and does not modify PMC binding files. > >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + type: object >>> + additionalProperties: true >> >> No, this cannot be "true". > > Agreed, I dropped that structure and kept strict schema validation. So open v5 and tell me how did you solve "this cannot be 'true'", part? Best regards, Krzysztof