From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Hamza Mahfooz" <hamzamahfooz@linux.microsoft.com>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
linux-rtc@vger.kernel.org
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v3 1/2] ACPI: TAD: introduce acpi_has_rtc()
Date: Tue, 27 Oct 2026 12:02:13 +0100 [thread overview]
Message-ID: <8214320a-d7fd-43b8-bc77-bc8425642c21@app.fastmail.com> (raw)
In-Reply-To: <20261026152103.3109313-1-hamzamahfooz@linux.microsoft.com>
Hello Hamza,
On Mon, 26 Oct 2026, at 16:21, Hamza Mahfooz wrote:
> The same RTC may also be accessible by other means, like the EFI
> GetTime() and SetTime() runtime services used by rtc-efi, which are best
> avoided if there is a native ACPI interface to the RTC.
>
> To allow other RTC drivers to stand down in that case, add an exported
> helper, acpi_has_rtc(), that returns true if there is a TAD the driver
> will register an RTC class device for.
>
> The helper looks for a platform device matching the driver's ID table
> whose _GCP indicates real time support, like acpi_tad_probe() checks,
> instead of checking whether the driver has bound to such a device, so
> that callers need not depend on the order in which drivers are probed.
>
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
> ---
> v1:
> https://lore.kernel.org/r/20261022211304.2285792-1-hamzamahfooz@linux.microsoft.com/
> v2:
> - Rename acpi_tad_rtc_available() to acpi_has_rtc(), move it to within
> acpi-tad (which allows us to simplify it quite a bit) and declare it
> in linux/acpi.h. (Ard)
> - Add acpi_disabled check. (Ard)
Next time, please use a cover latter when sending a series, so that you
can capture these changelogs in one place.
The series looks good to me:
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
I'll let Rafael and Alexandre decide how to queue this, once they are
happy with the patches as well.
next prev parent reply other threads:[~2026-10-27 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 15:21 [PATCH v3 1/2] ACPI: TAD: introduce acpi_has_rtc() Hamza Mahfooz
2026-10-26 15:21 ` [PATCH v3 2/2] rtc: efi: defer to the ACPI TAD if it can drive the RTC Hamza Mahfooz
2026-10-26 15:26 ` sashiko-bot
2026-10-26 15:30 ` [PATCH v3 1/2] ACPI: TAD: introduce acpi_has_rtc() sashiko-bot
2026-10-27 11:02 ` Ard Biesheuvel [this message]
2026-10-27 11:53 ` Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8214320a-d7fd-43b8-bc77-bc8425642c21@app.fastmail.com \
--to=ardb@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=hamzamahfooz@linux.microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox