From: Heiner Kallweit <hkallweit1@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
enric.balletbo@collabora.com
Cc: linux-rtc@vger.kernel.org
Subject: Re: rtc: ds1307: call the platform's logic for handle IRQs.
Date: Thu, 24 Aug 2017 20:46:14 +0200 [thread overview]
Message-ID: <832da9eb-abed-67c9-1d53-34f19d27c0d9@gmail.com> (raw)
Hi Enric,
I just saw your submitted patch on patchwork. As I haven't been subscribed
to linux-rtc list yet, I can't reply to the original mail.
Few remarks:
I think the same can be achieved easier (apart from the fact that member
irq was just removed from struct ds1307).
The curent call to device_set_wakeup_capable has to be replaced with
device_init_wakeup, in addition we have to call dev_pm_set_wake_irq to
register the interrupt with the Linux wakeup core. Then the core takes
care of everything.
See also rtc-ds1343, although I think the calls to enable/disable_irq_wake
are not needed there because the core takes care of this already
(enable_irq_wake is called from dev_pm_arm_wake_irq).
Rgds, Heiner
next reply other threads:[~2017-08-24 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 18:46 Heiner Kallweit [this message]
2017-08-24 19:16 ` rtc: ds1307: call the platform's logic for handle IRQs Heiner Kallweit
2017-08-24 20:13 ` Enric Balletbo i Serra
2017-08-24 20:44 ` Heiner Kallweit
2017-08-24 20:53 ` Heiner Kallweit
2017-08-25 6:43 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832da9eb-abed-67c9-1d53-34f19d27c0d9@gmail.com \
--to=hkallweit1@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox