From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF651A717 for ; Wed, 11 Oct 2023 09:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="l5sh4dOz"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QxJnYCZj" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A12E94; Wed, 11 Oct 2023 02:12:27 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697015545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mHTnG4MfEd2WInpkSaCyoIk5Nbax8kxNBig7AwLSEU=; b=l5sh4dOzDZ2X5HB7Xi84ttICGEA/Gzkkha41sxLmx8M1qkMsMpYCG0Xnyt/vGoVR0Dbdjy ucI9k/OtsU/Er7zqcw00spV0cvJPo8qfx2tD3YPpBhY0FsWc5l8QHCRzkkJmx1fffCitpK p3KWoVHzp++qoCf8dlfDVFuEtfML3i0rNKwNitl84UoRHNZN9AAmKlVTliBtrwQaQZlHcc +UrlmjwOIV/vAWWxlbAC1SBwNYR5Gymwi67+BIgiBXfjMjMllp22y0hZga4sAYbDkS36Fo sJnENvRXJ20gGfmlw9LvJsEEA5EcKGm5czz2PAlXomLE/TJQXC7jLHM8Xrnp8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697015545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mHTnG4MfEd2WInpkSaCyoIk5Nbax8kxNBig7AwLSEU=; b=QxJnYCZjXLEtyBI07eDRRe9WPqv1ZDHIwowp2BRGFJbN8R4Ajg6bj5fwV7Th8ozoNOCQOJ iYr4BRUAc4t+t+Cw== To: Biju Das , Geert Uytterhoeven Cc: Alessandro Zummo , Alexandre Belloni , John Stultz , Stephen Boyd , Douglas Anderson , Geert Uytterhoeven , Biju Das , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Greg Kroah-Hartman Subject: RE: [PATCH v2] alarmtimer: Fix rebind failure In-Reply-To: References: <20230922081208.26334-1-biju.das.jz@bp.renesas.com> <87il7fq1al.ffs@tglx> <87fs2jpznr.ffs@tglx> <87bkd7pic3.ffs@tglx> <87o7h6o6d1.ffs@tglx> Date: Wed, 11 Oct 2023 11:12:25 +0200 Message-ID: <87r0m1ldza.ffs@tglx> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Oct 11 2023 at 06:58, Biju Das wrote: >> On Tue, Oct 10, 2023 at 5:16=E2=80=AFPM Thomas Gleixner wrote: >>=20 >> The "if (alarmtimer_get_rtcdev()) { ... }" you pointed out in the probe >> function seems to be rather fragile, as it depends on probe order. And >> both CHARGER_MANAGER and RTC_DRV_88PM860X can be modular. > > Does it mean that current patch is fine? On normal scenario, no one > will remove RTC device, so nothing to worry about battery charger. On > exceptional cases if anyone wants to remove RTC driver, this patch > will help(for eg: checking resource leak remove/unbind followed by > modprobe/bind). Did you actually read what I wrote? Allowing removal of a registered RTC alarm device is a user space visible change as it violates the assumption that an armed alarm timer is actually functional. So unless you provide a proper analysis why this does not matter, this is going nowhere. Thanks, tglx