* [PATCH] rtc: dt-binding: abx80x: fix resistance scale
@ 2018-11-19 12:34 Baruch Siach
2018-11-22 17:18 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2018-11-19 12:34 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, Baruch Siach
The abracon,tc-resistor property value is in KOhm.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
index be789685a1c2..e668b5f65314 100644
--- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
+++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
@@ -27,4 +27,4 @@ and valid to enable charging:
- "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
- "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
- resistor, the other values are in ohm.
+ resistor, the other values are in KOhm.
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: dt-binding: abx80x: fix resistance scale
2018-11-19 12:34 [PATCH] rtc: dt-binding: abx80x: fix resistance scale Baruch Siach
@ 2018-11-22 17:18 ` Alexandre Belloni
2018-11-22 17:50 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2018-11-22 17:18 UTC (permalink / raw)
To: Baruch Siach; +Cc: linux-rtc
On 19/11/2018 14:34:02+0200, Baruch Siach wrote:
> The abracon,tc-resistor property value is in KOhm.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> index be789685a1c2..e668b5f65314 100644
> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> @@ -27,4 +27,4 @@ and valid to enable charging:
>
> - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
> - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
> - resistor, the other values are in ohm.
> + resistor, the other values are in KOhm.
The correct SI prefix is k so this should be kOhm. If you agree, I can
fix this up.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: dt-binding: abx80x: fix resistance scale
2018-11-22 17:18 ` Alexandre Belloni
@ 2018-11-22 17:50 ` Baruch Siach
0 siblings, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2018-11-22 17:50 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc
Hi Alexandre,
Alexandre Belloni writes:
> On 19/11/2018 14:34:02+0200, Baruch Siach wrote:
>> The abracon,tc-resistor property value is in KOhm.
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> index be789685a1c2..e668b5f65314 100644
>> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> @@ -27,4 +27,4 @@ and valid to enable charging:
>>
>> - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
>> - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
>> - resistor, the other values are in ohm.
>> + resistor, the other values are in KOhm.
>
> The correct SI prefix is k so this should be kOhm. If you agree, I can
> fix this up.
I am fine with that. Please fix the commit message as well.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-22 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-19 12:34 [PATCH] rtc: dt-binding: abx80x: fix resistance scale Baruch Siach
2018-11-22 17:18 ` Alexandre Belloni
2018-11-22 17:50 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).