* [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code
@ 2019-04-01 5:29 Anson Huang
2019-04-01 7:57 ` Mukesh Ojha
2019-04-01 13:12 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Anson Huang @ 2019-04-01 5:29 UTC (permalink / raw)
To: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/rtc/rtc-snvs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
index ce73eab..e0edd594 100644
--- a/drivers/rtc/rtc-snvs.c
+++ b/drivers/rtc/rtc-snvs.c
@@ -272,7 +272,6 @@ static const struct regmap_config snvs_rtc_config = {
static int snvs_rtc_probe(struct platform_device *pdev)
{
struct snvs_rtc_data *data;
- struct resource *res;
int ret;
void __iomem *mmio;
@@ -284,9 +283,8 @@ static int snvs_rtc_probe(struct platform_device *pdev)
if (IS_ERR(data->regmap)) {
dev_warn(&pdev->dev, "snvs rtc: you use old dts file, please update it\n");
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mmio = devm_ioremap_resource(&pdev->dev, res);
+ mmio = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(mmio))
return PTR_ERR(mmio);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:29 [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code Anson Huang
@ 2019-04-01 7:57 ` Mukesh Ojha
2019-04-01 13:12 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-04-01 7:57 UTC (permalink / raw)
To: Anson Huang, a.zummo@towertech.it, alexandre.belloni@bootlin.com,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
On 4/1/2019 10:59 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-snvs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
> index ce73eab..e0edd594 100644
> --- a/drivers/rtc/rtc-snvs.c
> +++ b/drivers/rtc/rtc-snvs.c
> @@ -272,7 +272,6 @@ static const struct regmap_config snvs_rtc_config = {
> static int snvs_rtc_probe(struct platform_device *pdev)
> {
> struct snvs_rtc_data *data;
> - struct resource *res;
> int ret;
> void __iomem *mmio;
>
> @@ -284,9 +283,8 @@ static int snvs_rtc_probe(struct platform_device *pdev)
>
> if (IS_ERR(data->regmap)) {
> dev_warn(&pdev->dev, "snvs rtc: you use old dts file, please update it\n");
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
Remove this blank line.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> - mmio = devm_ioremap_resource(&pdev->dev, res);
> + mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmio))
> return PTR_ERR(mmio);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:29 [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:57 ` Mukesh Ojha
@ 2019-04-01 13:12 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2019-04-01 13:12 UTC (permalink / raw)
To: Anson Huang
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, dl-linux-imx
On 01/04/2019 05:29:13+0000, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-snvs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-01 5:29 [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 7:57 ` Mukesh Ojha
2019-04-01 13:12 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).