From: Maninder Singh <maninder1.s@samsung.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: [rtc-linux] Re: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check
Date: Wed, 15 Jul 2015 03:12:05 +0000 (GMT) [thread overview]
Message-ID: <948552175.761871436929924254.JavaMail.weblogic@ep2mlwas06a> (raw)
Hello
>> removing below static analysis error:-
>What tool did you use?
Its coverity analysis (static analysis) tool.
Or you can also use cppcheck tool.
>> (error) Possible null pointer dereference: client
>>
>> if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
>> ^^^^^^^
>> Error comes beacause client is dereferenced before NULL check.
>> So probabily NULL this check is not required.
>>
>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> ---
>> drivers/rtc/rtc-bq32k.c | 2 +-
>Applied, to rtc-next.
Thanks.
Maninder
............
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next reply other threads:[~2015-07-15 3:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 3:12 Maninder Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-08 6:56 [rtc-linux] [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check Maninder Singh
2015-07-14 22:41 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=948552175.761871436929924254.JavaMail.weblogic@ep2mlwas06a \
--to=maninder1.s@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=pankaj.m@samsung.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox