From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH v1 3/4] ACPI: TAD: Split acpi_tad_rtc_set_time()
Date: Tue, 31 Mar 2026 21:26:23 +0200 [thread overview]
Message-ID: <9619488.CDJkKcVGEf@rafael.j.wysocki> (raw)
In-Reply-To: <2366642.iZASKD2KPV@rafael.j.wysocki>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Move the code converting a struct acpi_tad_rt into a struct rtc_time
from acpi_tad_rtc_set_time() into a new function, acpi_tad_rt_to_tm(),
to facilitate adding alarm support to the driver's RTC class device
interface going forward.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/acpi_tad.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
--- a/drivers/acpi/acpi_tad.c
+++ b/drivers/acpi/acpi_tad.c
@@ -617,6 +617,17 @@ static const struct attribute_group *acp
#ifdef CONFIG_RTC_CLASS
/* RTC class device interface */
+static void acpi_tad_rt_to_tm(struct acpi_tad_rt *rt, struct rtc_time *tm)
+{
+ tm->tm_year = rt->year - 1900;
+ tm->tm_mon = rt->month - 1;
+ tm->tm_mday = rt->day;
+ tm->tm_hour = rt->hour;
+ tm->tm_min = rt->minute;
+ tm->tm_sec = rt->second;
+ tm->tm_isdst = rt->daylight == ACPI_TAD_TIME_ISDST;
+}
+
static int acpi_tad_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
struct acpi_tad_rt rt;
@@ -642,13 +653,7 @@ static int acpi_tad_rtc_read_time(struct
if (ret)
return ret;
- tm->tm_year = rt.year - 1900;
- tm->tm_mon = rt.month - 1;
- tm->tm_mday = rt.day;
- tm->tm_hour = rt.hour;
- tm->tm_min = rt.minute;
- tm->tm_sec = rt.second;
- tm->tm_isdst = rt.daylight == ACPI_TAD_TIME_ISDST;
+ acpi_tad_rt_to_tm(&rt, tm);
return 0;
}
next prev parent reply other threads:[~2026-03-31 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 19:23 [PATCH v1 0/4] ACPI: TAD: Add alarm support to RTC class device interface Rafael J. Wysocki
2026-03-31 19:24 ` [PATCH v1 1/4] ACPI: TAD: Split three functions to untangle runtime PM handling Rafael J. Wysocki
2026-03-31 19:25 ` [PATCH v1 2/4] ACPI: TAD: Relocate two functions Rafael J. Wysocki
2026-03-31 19:26 ` Rafael J. Wysocki [this message]
2026-03-31 19:38 ` [PATCH v1 4/4] ACPI: TAD: Add alarm support to the RTC class device interface Rafael J. Wysocki
2026-04-03 15:34 ` [PATCH v1 0/4] ACPI: TAD: Add alarm support to " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9619488.CDJkKcVGEf@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox