From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Shunxi Zhang (章顺喜)" <ot_shunxi.zhang@mediatek.com>,
"Sean Wang" <Sean.Wang@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"lee@kernel.org" <lee@kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Sirius Wang (王皓昱)" <Sirius.Wang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jh Hsu (許希孜)" <Jh.Hsu@mediatek.com>,
"Vince-WL Liu (劉文龍)" <Vince-WL.Liu@mediatek.com>
Subject: Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU register
Date: Tue, 19 Aug 2025 10:16:06 +0200 [thread overview]
Message-ID: <97cb6271-9881-40e0-83a6-e41f14c85865@kernel.org> (raw)
In-Reply-To: <40342432bf4638b54615b70320f72095f18c0490.camel@mediatek.com>
On 19/08/2025 09:54, Shunxi Zhang (章顺喜) wrote:
>>> #define RTC_BBPU 0x0000
>>> +#define RTC_BBPU_PWREN BIT(0)
>>> +#define RTC_BBPU_CLR BIT(1)
>>> +#define RTC_BBPU_RESET_AL BIT(3)
>>> #define RTC_BBPU_CBUSY BIT(6)
>>> -#define RTC_BBPU_KEY (0x43 << 8)
>>> +#define RTC_BBPU_KEY (0x43 << 8)
>>
>>
>> Why?
>>
>>
>>
>> Best regards,
>> Krzysztof
>
> Dear sir,
> The MT6397 is an integration of several ICs and does not have a
> separate IC specification. I will check the relevant IC datasheets
> again. I will remove the useless define in next version.
I understand nothing from this reply. I do not see it related to my
questions at all. Do you want to say that you change indentation,
because MT6397 is integration? That makes absolutely NO SENSE!
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-19 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 8:15 [PATCH v1 0/2] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling ot_shunxi.zhang
2025-08-11 8:15 ` [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU register ot_shunxi.zhang
2025-08-11 11:02 ` Krzysztof Kozlowski
2025-08-11 11:21 ` Giorgi Tchankvetadze
2025-08-19 7:53 ` Shunxi Zhang (章顺喜)
2025-08-19 7:54 ` Shunxi Zhang (章顺喜)
2025-08-19 8:16 ` Krzysztof Kozlowski [this message]
2025-08-19 8:32 ` Shunxi Zhang (章顺喜)
2025-08-11 8:15 ` [PATCH v1 2/2] rtc: mt6397: Add BBPU alarm status reset and shutdown handling ot_shunxi.zhang
2025-08-11 13:09 ` Alexandre Belloni
2025-08-19 7:48 ` Shunxi Zhang (章顺喜)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97cb6271-9881-40e0-83a6-e41f14c85865@kernel.org \
--to=krzk@kernel.org \
--cc=Jh.Hsu@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=Sirius.Wang@mediatek.com \
--cc=Vince-WL.Liu@mediatek.com \
--cc=alexandre.belloni@bootlin.com \
--cc=eddie.huang@mediatek.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_shunxi.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).