From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Vladimir Zapolskiy <vz@mleia.com>, Joel Stanley <joel@jms.id.au>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: rtc: convert trivial devices into dtschema
Date: Mon, 15 Apr 2024 08:35:04 +0200 [thread overview]
Message-ID: <9b33192d-6245-45e1-bcba-c2339e18f77c@gmail.com> (raw)
In-Reply-To: <82fcd7a4532df119f82ea55208f592460ba5358e.camel@codeconstruct.com.au>
On 4/15/24 02:09, Andrew Jeffery wrote:
> On Sat, 2024-04-13 at 22:22 +0200, Javier Carrasco wrote:
>> These RTCs meet the requirements for a direct conversion into
>> trivial-rtc:
>>
>> - google,goldfish-rtc
>> - maxim,ds1742
>> - lpc32xx-rtc
>> - orion-rtc
>> - rtc-aspeed
>> - spear-rtc
>> - via,vt8500-rtc
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> We have trailers above but then there's more commit message content
> below. Looks like what's below should be trimmed out (bad squash)?
> Maybe the trimming could be done as its applied?
>
>>
>> dt-bindings: rtc: lpc32xx-rtc: convert to dtschema
>>
>> Convert existing binding to dtschema to support validation.
>>
>> Add the undocumented 'clocks' property.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> Andrew
You are right, the commit message content below your comment should not
be there. I can send a new version to trim it away if that is preferred.
Best regards,
Javier Carrasc
next prev parent reply other threads:[~2024-04-15 6:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 20:22 [PATCH v3 0/4] rtc: convert multiple bindings into dtschema Javier Carrasco
2024-04-13 20:22 ` [PATCH v3 1/4] arm: dts: nxp: lpc: lpc32xx: drop 'clocks' form rtc Javier Carrasco
2024-06-03 10:24 ` Javier Carrasco
2024-04-13 20:22 ` [PATCH v3 2/4] dt-bindings: rtc: convert trivial devices into dtschema Javier Carrasco
2024-04-15 0:09 ` Andrew Jeffery
2024-04-15 6:35 ` Javier Carrasco [this message]
2024-04-13 20:22 ` [PATCH v3 3/4] dt-bindings: rtc: pxa-rtc: convert to dtschema Javier Carrasco
2024-04-13 20:22 ` [PATCH v3 4/4] dt-bindings: rtc: stmp3xxx-rtc: " Javier Carrasco
2024-04-13 21:11 ` Krzysztof Kozlowski
2024-04-17 19:36 ` (subset) [PATCH v3 0/4] rtc: convert multiple bindings into dtschema Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b33192d-6245-45e1-bcba-c2339e18f77c@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).