Re: [PATCH 0/5] Add support for the Microsoft Surface Pro X

[Haipeng Lin <jimmie.lin@gmail.com>]

On 11/4/26 2:04 AM, Val Packett wrote:
> The Surface Pro X is a 2019-era tablet powered by the Qualcomm SC8180X SoC,
> released in three variants (SQ1, Wi-Fi, SQ2).
> 
> Patches to support it have been around in a downstream tree at
> https://github.com/linux-surface/kernel for a while. Let's upstream it!
> 
> I have permission from Maximilian Luz to use his From/S-o-b with modified
> (squashed, stripped down and split by model variant) patches:
> https://github.com/linux-surface/surface-pro-x/issues/7#issuecomment-6597291831
> [...]

Hi Val,

Thanks for your work upstreaming this. I've been running the 
linux-surface SPX patches on my Surface Pro X Wi-Fi SQ2
(Surface_Pro_X_2010) for a while and tested this series on it (v7.4-rc1
+ your SLPI + this series) plus a few fixups needed to get it working:

1. Labels for smb2351_2 (pmic@2) and smb2351_a (pmic@a) in
   sc8180x-pmics.dtsi so the board DTS files build.

2. &qupv3_id_2 { status = "okay"; } in the SPX dtsi so uart13 (BT) and
   uart15 (SAM EC) are populated.

3. Tested caspar.dtb as-is but this will cap CPU4 at 2.995 GHz (SQ1
   clocks). Added carina's two SQ2 CPU4 OPPs to reach 3.15 GHz on my
   SQ2 Wi-Fi. Please see reply to 2/5.

4. Wi-Fi: I had to revert v7.4-rc1 544d85de4dc2 ("net: qrtr: Send HELLO
   message on endpoint registration") otherwise MPSS hits a fatal error
   ~40s after every start and crash-loops. Wi-Fi associates but never 
   passes traffic.
   After reverting it the modem starts up so this may be a regression
   unrelated to this series.

With the fixups noted above, for
- Surface Pro X Wi-Fi SQ2 (Surface_Pro_X_2010)

Tested-by: Haipeng Lin <jimmie.lin@gmail.com>

Happy to re-test v2 on this unit if needed.

Thanks,
Haipeng