From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8976C6FD18 for ; Tue, 25 Apr 2023 09:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233612AbjDYJ2j (ORCPT ); Tue, 25 Apr 2023 05:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbjDYJ2h (ORCPT ); Tue, 25 Apr 2023 05:28:37 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F143A85 for ; Tue, 25 Apr 2023 02:28:36 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50506ac462bso8220452a12.3 for ; Tue, 25 Apr 2023 02:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682414915; x=1685006915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jATRlbjXv5J+rEp492wNPd1HzXNCpPqK/mHv12ah7jo=; b=U6wrCMhlhs3lK2GT2Q6zJRS74H8+DpdTbKJ7VhiKEkxpAbStuZUYTlajchnT2wyaK5 S+8v3hlHMsjea0L6q/7bfM5OlzsT+uIb56SwiSqvJUyEKJVx449i9d/reE4qM8HG0kv/ yNUV8Fk1D9eHz+wEDc6NatiLFSwOI75HZa3P/EkjgQz0qUWoxWLpjtai4AY5SpKHEk2k vUdKDkPz/5Z9ZfYm3EfOGw1R2NxNGs0zFABFduFJRiq728amWxtTKBKxVFi/tNbv9XQF PyIVwu7zedxxeJV9rVZJFC046JX0x+OM3CRdMd8B9R6oLe6ikNBYV0v3by5tVWO+pETS uxfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682414915; x=1685006915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jATRlbjXv5J+rEp492wNPd1HzXNCpPqK/mHv12ah7jo=; b=VggIggjhGzoJFxiSCHTrfJUz8MdbkcvOMC9YiHA4CktZT7j+LvqpueZpk6o98lmj1r W8xCO0Alwp2H/W5gkbYOwgRt2pV0p/9UL6eNeePkaEawL1rg7rWsfTugpSP19n+loyyM fAG920XwA0i/RQ8FqeEtBi0zG9P/o4luWW7iDWQq39La+yxL7sCak5IzQZZFl5gAbqbW MmfWaLcrfzg2JUFDNEdaGrH+fDGyOx1FWgOh92QFGUsX/YZwEDoomn5w4Lj3yKP/yqE9 tuvbFopUynrfmIcDwr7IuHpUfuHo3q9++FhBv6z5r2PMhfeldRQYC2E/syPXHWAJ5TXl v7KA== X-Gm-Message-State: AAQBX9fUjNvkC+M/32tlANySSjPtH8y1tLkfnH3Hi2QuC13ZQ5dlbAR1 p7hw2xL6hRNHngWSW4DXhn9pgGPn5/KMvk9kePSpEeFJ X-Google-Smtp-Source: AKy350bpVOT/qCWlTtSfAS77lfzKvlDUH4Ja386ohyjISP/id/ad2bl27gQyQJ1quqMcOLW79J/yPA== X-Received: by 2002:aa7:d494:0:b0:506:6c4d:3292 with SMTP id b20-20020aa7d494000000b005066c4d3292mr13157772edr.25.1682414914811; Tue, 25 Apr 2023 02:28:34 -0700 (PDT) Received: from [192.168.9.102] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id t1-20020aa7d4c1000000b005066cadcc54sm5486122edr.43.2023.04.25.02.28.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 02:28:34 -0700 (PDT) Message-ID: <9e7583be-ad4a-0ccc-08f6-cdf3fa4ed6bd@linaro.org> Date: Tue, 25 Apr 2023 11:28:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 07/43] dt-bindings: rtc: add DT bindings for Cirrus EP93xx Content-Language: en-US To: Nikita Shubin Cc: Arnd Bergmann , Linus Walleij , Alexander Sverdlin , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Hartley Sweeten , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230424123522.18302-8-nikita.shubin@maquefel.me> From: Krzysztof Kozlowski In-Reply-To: <20230424123522.18302-8-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 24/04/2023 14:34, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > RTC block used in these SoCs. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Nikita Shubin > --- > .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > new file mode 100644 > index 000000000000..d4774e984e7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus EP93xx Real Time Clock controller > + > +maintainers: > + - Hartley Sweeten > + - Alexander Sverdlin > + > +properties: > + compatible: > + const: cirrus,ep9301-rtc Why only one compatible? What about ep9307 and ep9312? The same question for your previous patch - timer. Anyway, if you want to keep it like that, then filename should match compatible. Or merge it into trivial-rtc like Alexandre suggested. Best regards, Krzysztof