From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Brandt <chris.brandt@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/3] rtc: sh: stop resetting time to epoch
Date: Thu, 21 Mar 2019 10:46:19 +0100 [thread overview]
Message-ID: <CAMuHMdX8rabWxvQzMGmrckqdrtDA-J+HTuatO3BsgJwLjpxaFQ@mail.gmail.com> (raw)
In-Reply-To: <20190320113010.8955-1-alexandre.belloni@bootlin.com>
Hi Alexandre,
On Wed, Mar 20, 2019 at 12:30 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> There is no point in resetting the time to epoch as this means that
> userspace will never get the valuable information that time is actually
> invalid.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Impact before/after (cold boot):
-sh-rtc fcff1000.rtc: setting system clock to 1970-01-01T00:00:00 UTC (0)
+sh-rtc fcff1000.rtc: hctosys: unable to read the hardware clock
After warm boot (Linux reboot command):
sh-rtc fcff1000.rtc: setting system clock to 2019-03-21T08:47:54
UTC (1553158074)
After reset (reset switch):
sh-rtc fcff1000.rtc: hctosys: unable to read the hardware clock
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2019-03-21 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:30 [PATCH 1/3] rtc: sh: stop resetting time to epoch Alexandre Belloni
2019-03-20 11:30 ` [PATCH 2/3] rtc: sh: fix possible race condition Alexandre Belloni
2019-03-21 9:51 ` Geert Uytterhoeven
2019-03-20 11:30 ` [PATCH 3/3] rtc: sh: set range Alexandre Belloni
2019-03-21 10:22 ` Geert Uytterhoeven
2019-03-22 6:12 ` Alexandre Belloni
2019-03-22 7:26 ` Geert Uytterhoeven
2019-03-21 9:46 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX8rabWxvQzMGmrckqdrtDA-J+HTuatO3BsgJwLjpxaFQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=alexandre.belloni@bootlin.com \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).