From: Baolin Wang <baolin.wang@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] rtc: sc27xx: remove .remove
Date: Tue, 22 Oct 2019 09:56:51 +0800 [thread overview]
Message-ID: <CAMz4kuLtCWC7s3Q8QRuOYE6PR186CDNQMvLNTSiVuHhGyz4Jzg@mail.gmail.com> (raw)
In-Reply-To: <20191021155806.3625-4-alexandre.belloni@bootlin.com>
On Mon, 21 Oct 2019 at 23:58, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> dpm_sysfs_remove() and device_pm_remove() are already called by
> device_del() on device removal so there is no need to call
> device_init_wakeup(dev, false) from the driver and it allows to remove the
> .remove callback.
Right, feel free to add my tag, thanks.
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-sc27xx.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
> index b95676899750..36810dd40cd3 100644
> --- a/drivers/rtc/rtc-sc27xx.c
> +++ b/drivers/rtc/rtc-sc27xx.c
> @@ -661,12 +661,6 @@ static int sprd_rtc_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int sprd_rtc_remove(struct platform_device *pdev)
> -{
> - device_init_wakeup(&pdev->dev, 0);
> - return 0;
> -}
> -
> static const struct of_device_id sprd_rtc_of_match[] = {
> { .compatible = "sprd,sc2731-rtc", },
> { },
> @@ -679,7 +673,6 @@ static struct platform_driver sprd_rtc_driver = {
> .of_match_table = sprd_rtc_of_match,
> },
> .probe = sprd_rtc_probe,
> - .remove = sprd_rtc_remove,
> };
> module_platform_driver(sprd_rtc_driver);
>
> --
> 2.21.0
>
--
Baolin Wang
Best Regards
prev parent reply other threads:[~2019-10-22 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:58 [PATCH 1/4] rtc: ab-b5ze-s3: remove .remove Alexandre Belloni
2019-10-21 15:58 ` [PATCH 2/4] rtc: lpc32xx: " Alexandre Belloni
2019-10-21 15:58 ` [PATCH 3/4] rtc: sirfsoc: " Alexandre Belloni
2019-10-21 15:58 ` [PATCH 4/4] rtc: sc27xx: " Alexandre Belloni
2019-10-22 1:56 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuLtCWC7s3Q8QRuOYE6PR186CDNQMvLNTSiVuHhGyz4Jzg@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).