From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Lee Jones" <lee@kernel.org>, "Yixun Lan" <dlan@gentoo.org>,
"Alex Elder" <elder@riscstar.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
<linux-i2c@vger.kernel.org>, <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] regulator: spacemit: MFD_SPACEMIT_P1 as dependencies
Date: Mon, 12 Jan 2026 09:51:58 +0800 [thread overview]
Message-ID: <DFM8GN2AWH1A.1FWVNVF5FLDSH@linux.spacemit.com> (raw)
In-Reply-To: <20260109224147267169ba@mail.local>
On Sat Jan 10, 2026 at 6:41 AM CST, Alexandre Belloni wrote:
> On 08/01/2026 16:38:54+0800, Troy Mitchell wrote:
>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
>> index d2335276cce5ffbd500bbaf251d1761a9116aee9..b51888a9a78f399a6af3294fc19f60792576332c 100644
>> --- a/drivers/regulator/Kconfig
>> +++ b/drivers/regulator/Kconfig
>> @@ -1496,9 +1496,8 @@ config REGULATOR_SLG51000
>> config REGULATOR_SPACEMIT_P1
>> tristate "SpacemiT P1 regulators"
>> depends on ARCH_SPACEMIT || COMPILE_TEST
>> - depends on I2C
>> - select MFD_SPACEMIT_P1
>> - default ARCH_SPACEMIT
>> + depends on MFD_SPACEMIT_P1
>> + default m if MFD_SPACEMIT_P1
>
> default MFD_SPACEMIT_P1 is certainly enough here.
Yes, Thanks!
I'll use it in the next version.
- Troy
next prev parent reply other threads:[~2026-01-12 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:38 [PATCH v5 0/3] spacemit: fix P1 sub-device Kconfig defaults and dependencies Troy Mitchell
2026-01-08 8:38 ` [PATCH v5 1/3] regulator: spacemit: MFD_SPACEMIT_P1 as dependencies Troy Mitchell
2026-01-09 22:41 ` Alexandre Belloni
2026-01-12 1:51 ` Troy Mitchell [this message]
2026-01-08 8:38 ` [PATCH v5 2/3] mfd: simple-mfd-i2c: add default value Troy Mitchell
2026-01-13 12:42 ` Lee Jones
2026-01-14 7:40 ` Troy Mitchell
2026-01-08 8:38 ` [PATCH v5 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled Troy Mitchell
2026-01-09 22:38 ` Alexandre Belloni
2026-01-11 19:58 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFM8GN2AWH1A.1FWVNVF5FLDSH@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox