From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Lee Jones" <lee@kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Yixun Lan" <dlan@gentoo.org>, "Alex Elder" <elder@riscstar.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
<linux-i2c@vger.kernel.org>, <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v5 2/3] mfd: simple-mfd-i2c: add default value
Date: Wed, 14 Jan 2026 15:40:26 +0800 [thread overview]
Message-ID: <DFO54J7CRS8U.1D9XZAJHF57HM@linux.spacemit.com> (raw)
In-Reply-To: <20260113124241.GB2842980@google.com>
On Tue Jan 13, 2026 at 8:42 PM CST, Lee Jones wrote:
> On Thu, 08 Jan 2026, Troy Mitchell wrote:
>
>> The default value of the P1 sub-device depends on the value
>> of P1, so P1 should have a default value here.
>>
>> Acked-by: Alex Elder <elder@riscstar.com>
>> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>> ---
>> Change log in v5:
>> - nothing
>> - Link to v4: https://lore.kernel.org/all/20251225-p1-kconfig-fix-v4-2-44b6728117c1@linux.spacemit.com/
>>
>> Change log in v4:
>> - default m if ARCH_SPACEMIT instead of default ARCH_SPACEMIT
>> - Link to v3: https://lore.kernel.org/all/20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com/
>> ---
>> drivers/mfd/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index aace5766b38aa5e46e32a8a7b42eea238159fbcf..c757bc365029dc794c658fc5b10084a0f29ac9b6 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1276,6 +1276,7 @@ config MFD_SPACEMIT_P1
>> depends on ARCH_SPACEMIT || COMPILE_TEST
>> depends on I2C
>> select MFD_SIMPLE_MFD_I2C
>> + default m if ARCH_SPACEMIT
>> help
>> This option supports the I2C-based SpacemiT P1 PMIC, which
>> contains regulators, a power switch, GPIOs, an RTC, and more.
>
> I already applied v4.
Apologies, I missed this.
I will remove the patch in the next version. Thank you for your work.
- Troy
next prev parent reply other threads:[~2026-01-14 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:38 [PATCH v5 0/3] spacemit: fix P1 sub-device Kconfig defaults and dependencies Troy Mitchell
2026-01-08 8:38 ` [PATCH v5 1/3] regulator: spacemit: MFD_SPACEMIT_P1 as dependencies Troy Mitchell
2026-01-09 22:41 ` Alexandre Belloni
2026-01-12 1:51 ` Troy Mitchell
2026-01-08 8:38 ` [PATCH v5 2/3] mfd: simple-mfd-i2c: add default value Troy Mitchell
2026-01-13 12:42 ` Lee Jones
2026-01-14 7:40 ` Troy Mitchell [this message]
2026-01-08 8:38 ` [PATCH v5 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled Troy Mitchell
2026-01-09 22:38 ` Alexandre Belloni
2026-01-11 19:58 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFO54J7CRS8U.1D9XZAJHF57HM@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox