From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435C8C7EE39 for ; Mon, 29 May 2023 06:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbjE2GZC (ORCPT ); Mon, 29 May 2023 02:25:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbjE2GYu (ORCPT ); Mon, 29 May 2023 02:24:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F817EA; Sun, 28 May 2023 23:24:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14E76612DB; Mon, 29 May 2023 06:24:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1BE1C4339B; Mon, 29 May 2023 06:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685341457; bh=xZQ4c3sZfJ1nNEi2GqOvmmx6GGK5BJZioTZWTyJcUB4=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=okzVTHJLaVvykLXWWqT9sSAnbTsG6R8QSNm5nJZtaHcteF7moKcxFof5iXFKkjQoP whTfYpmf7wITNgUeZQY3/CMYYN49UwsjXJ3N9bM/8nRTuCw/t7/QUfDdqEvZSqddUF ZJOtRGIRS0uEEhi1gPXod8SJaxKe+fbomEZCcXCqbr1jMi/j7R2mM3mAAy9DBg1TJ8 RVTTT8q8CqdqA9wM2LtOhjbQv/1KYVFwqlHieMnihPuPdiBc6Jzcr82ySaf6LhcE5d 13oAJ9Pk0IbwUXy+E2HVjxQYXO5Xo7Jx8mMudbiXoi7X4tziqATloY6krK3RITdE7g pTP8URjybR0HA== Date: Mon, 29 May 2023 07:24:12 +0100 From: Conor Dooley To: Keguang Zhang CC: Jiaxun Yang , Binbin Zhou , Conor Dooley , Binbin Zhou , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Huacai Chen , Huacai Chen , Xuerui Wang , loongarch@lists.linux.dev, Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , zhao zhang , Yang Ling , loongson-kernel@lists.loongnix.cn Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_V4_1/5=5D_dt-bindings=3A_rtc=3A_?= =?US-ASCII?Q?Remove_the_LS2X_from_the_trivial_RTCs?= User-Agent: K-9 Mail for Android In-Reply-To: References: <9a2fbd6860f37760ca6089c150fd6f67628405f6.1684983279.git.zhoubinbin@loongson.cn> <20230525-custody-oversleep-f778eddf981c@spud> <20230526-dolly-reheat-06c4d5658415@wendy> <20230527-passing-unfixed-39e01b787808@spud> <14EF9F21-8150-40D9-8870-E9151C4882CF@flygoat.com> <20230527-poet-antarctic-cc02aa60ab52@spud> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 29 May 2023 03:59:57 IST, Keguang Zhang w= rote: >On Sun, May 28, 2023 at 6:22=E2=80=AFAM Conor Dooley = wrote: >> >> On Sat, May 27, 2023 at 10:59:48PM +0100, Jiaxun Yang wrote: >> > > 2023=E5=B9=B45=E6=9C=8827=E6=97=A5 17:23=EF=BC=8CConor Dooley =E5=86=99=E9=81=93=EF=BC=9A >> > > On Sat, May 27, 2023 at 05:13:39PM +0100, Jiaxun Yang wrote: >> >> > >> My recommendation is leaving compatible string as is=2E >> > > >> > > "as is" meaning "as it is right now in Linus' tree", or "as it is i= n >> > > this patch"? >> > >> > Ah sorry I meant in this patch=2E >> > >> > Since there won=E2=80=99t be any new ls1x chip that will boot Linux a= ny time soon (due to >> > Loongson move away from MIPS but LoongArch32 is undefined for now), a= nd >> > rest compatible strings are wide enough to cover their family, I thin= k the present >> > compatible strings in this patch describes hardware best=2E >> >> I don't see why new bindings being written for old hardware should some= how >> be treated differently than new bindings for new hardware=2E > >Let me add that ls1b RTC and ls1c RTC are not exactly the same=2E >The former supports RTC interrupt, while the latter does not=2E >So my suggestion is to leave the compatible string as it is in this patch= =2E Just as a reminder, there are more than ls1b & c in the patch, lest we for= get=2E Also, fallback compatibles mean a compatible subset, not only that two dev= ices are identical=2E The interrupt is passed by the interrupts property=2E