From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: "Angel Iglesias" <ang.iglesiasg@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
linux-i2c@vger.kernel.org, kernel@pengutronix.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 561/606] rtc: isl1208: Convert to i2c's .probe_new()
Date: Sun, 20 Nov 2022 00:58:44 +0100 [thread overview]
Message-ID: <Y3lttA22QlR46RXz@mail.local> (raw)
In-Reply-To: <20221118224540.619276-562-uwe@kleine-koenig.org>
On 18/11/2022 23:44:55+0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
This is already done later on in the function, please check the rtc
patches as I took your previous series.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/rtc/rtc-isl1208.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
> index 73cc6aaf9b8b..fca9cc440296 100644
> --- a/drivers/rtc/rtc-isl1208.c
> +++ b/drivers/rtc/rtc-isl1208.c
> @@ -799,6 +799,7 @@ static int isl1208_setup_irq(struct i2c_client *client, int irq)
> static int
> isl1208_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> int rc = 0;
> struct isl1208_state *isl1208;
> int evdet_irq = -1;
> --
> 2.38.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-11-19 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:44 ` [PATCH 560/606] rtc: ds1307: Convert to i2c's .probe_new() Uwe Kleine-König
2023-01-06 17:48 ` Uwe Kleine-König
2023-01-09 22:04 ` (subset) " Alexandre Belloni
2022-11-18 22:44 ` [PATCH 561/606] rtc: isl1208: " Uwe Kleine-König
2022-11-19 23:58 ` Alexandre Belloni [this message]
2022-11-20 20:30 ` Uwe Kleine-König
2022-11-18 22:44 ` [PATCH 562/606] rtc: m41t80: " Uwe Kleine-König
2022-11-18 22:44 ` [PATCH 563/606] rtc: rs5c372: " Uwe Kleine-König
2022-11-19 6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
2022-11-19 6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
2022-11-21 9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16 ` Uwe Kleine-König
2022-11-26 15:43 ` Andy Shevchenko
2022-12-09 12:00 ` (subset) " Robert Foss
2022-12-12 16:36 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3lttA22QlR46RXz@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=ang.iglesiasg@gmail.com \
--cc=grant.likely@linaro.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=uwe@kleine-koenig.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox