Re: [PATCH] dt-bindings: rtc: Add rv3028 to rv3032.yaml dtschema

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

On 30/12/2022 11:09:32+0000, Wadim Egorov wrote:
> Am 28.12.22 um 15:15 schrieb Krzysztof Kozlowski:
> > Your subject is a bit incorrect. You do not add rv3028 to rv3032.yaml.
> > Also drop redundant "dtschema". Instead "Extend rv3028 bindings"
> >
> >
> > On 28/12/2022 15:06, Wadim Egorov wrote:
> >> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml.
> >> RV3028 can have a trickle-resitor-ohms property. Make it known to dtschema.
> > I don't understand what is here made known to dtschema, so maybe drop
> > last sentence.
> >
> >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> >> ---
> >>   .../bindings/rtc/microcrystal,rv3028.yaml     | 56 +++++++++++++++++++
> >>   .../devicetree/bindings/rtc/trivial-rtc.yaml  |  2 -
> >>   2 files changed, 56 insertions(+), 2 deletions(-)
> >>   create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> >> new file mode 100644
> >> index 000000000000..4abe4756bc9b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> >> @@ -0,0 +1,56 @@
> >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/rtc/microcrystal,rv3028.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Microchip RV-3028 RTC
> >> +
> >> +allOf:
> >> +  - $ref: "rtc.yaml#"
> > Drop quotes.
> >
> >> +
> >> +maintainers:
> >> +  - Alexandre Belloni <alexandre.belloni@bootlin.com>
> > This should not be maintainer of subsystem but maintainer of device
> > (unless it is the same person?).
> >
> Hi Krzysztof,
> 
> who would be the maintainer for this RTC?
> I am not able to find a maintainer.
> 

I am the maintainer for this RTC driver

> Can I keep Alexandre Belloni as the maintainer since there seem to be no 
> maintainer for the RV3028 RTC.
> 
> Regards,
> Wadim
> 
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com