From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: rtc: moxart: use proper names for gpio properties
Date: Wed, 1 Feb 2023 11:02:39 -0800 [thread overview]
Message-ID: <Y9q3T17r5G2PD9Gk@google.com> (raw)
In-Reply-To: <20230201175504.GA4075318-robh@kernel.org>
On Wed, Feb 01, 2023 at 11:55:04AM -0600, Rob Herring wrote:
> On Wed, Feb 01, 2023 at 08:15:26AM -0800, Dmitry Torokhov wrote:
> > On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote:
> > > On 01/02/2023 06:48, Dmitry Torokhov wrote:
> > > > MOXA ART RTC driver has been switched to gpiod API and is now using
> > > > properly named properties for its gpios (with gpiolib implementing a
> > > > quirk to recognize legacy names). Change binding document to use
> > > > proper names as well.
> > > >
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > ---
> > > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------
> > > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
> > > > index c9d3ac1477fe..1374df7bf9d6 100644
> > > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
> > > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt
> > > > @@ -3,15 +3,15 @@ MOXA ART real-time clock
> > > > Required properties:
> > > >
> > > > - compatible : Should be "moxa,moxart-rtc"
> > > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags
> > > > -- gpio-rtc-data : RTC data gpio, with zero flags
> > > > -- gpio-rtc-reset : RTC reset gpio, with zero flags
> > > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags
> > > > +- rtc-data-gpios : RTC data gpio, with zero flags
> > > > +- rtc-reset-gpios : RTC reset gpio, with zero flags
> > >
> > > Your driver breaks the ABI, doesn't it? If not, how are the old
> > > properties parsed?
> >
> > It does not. As I mentioned in the driver code patch, commit
> > eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART
> > RTC") makes sure gpiolib falls back to trying old variants if it can't
> > locate properly formatted names.
>
> A dtb with the new names and a kernel without the gpiod conversion would
> be broken. Up to the platform whether they care really.
Seriously? And I guess devices with DTS do not work with kernels v2.0 so
we should never have introduced it...
I understand wanting backward compatibility, but asking for both
backward and forward is a bit too much IMO.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-02-01 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 5:48 [PATCH 1/3] rtc: moxart: switch to using gpiod API Dmitry Torokhov
2023-02-01 5:48 ` [PATCH 2/3] dt-bindings: rtc: moxart: use proper names for gpio properties Dmitry Torokhov
2023-02-01 7:38 ` Krzysztof Kozlowski
2023-02-01 16:15 ` Dmitry Torokhov
2023-02-01 17:55 ` Rob Herring
2023-02-01 19:02 ` Dmitry Torokhov [this message]
2023-02-02 23:27 ` Rob Herring
2023-02-03 22:22 ` Dmitry Torokhov
2023-02-01 5:48 ` [PATCH 3/3] ARM: dts: moxart: switch to proper names for RTC GPIOs Dmitry Torokhov
2023-02-09 22:32 ` (subset) [PATCH 1/3] rtc: moxart: switch to using gpiod API Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9q3T17r5G2PD9Gk@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).