From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F86C433ED for ; Sun, 9 May 2021 21:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47D25613F0 for ; Sun, 9 May 2021 21:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbhEIVHc (ORCPT ); Sun, 9 May 2021 17:07:32 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:55437 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbhEIVHb (ORCPT ); Sun, 9 May 2021 17:07:31 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1863D1BF207; Sun, 9 May 2021 21:06:26 +0000 (UTC) Date: Sun, 9 May 2021 23:06:25 +0200 From: Alexandre Belloni To: Edmundo Carmona Antoranz Cc: Christophe JAILLET , cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: max77686: Remove some dead code Message-ID: References: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 08/05/2021 18:06:03-0600, Edmundo Carmona Antoranz wrote: > On Sat, May 8, 2021 at 10:59 AM Christophe JAILLET > wrote: > > > > > > > > Following the recent conversations, I think it might make sense to do > > > dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); > > > > > > Is that right? > > > > > > > Yes, it is right, but it should be done in another patch. > > > > Would you like to give it a try? > > > Sure, I'll have the patch ready to send it when I see yours on next. Does it make sense to print anything at all? Who would use the output? Is anyone actually going to read it? -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com