From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0BAC433B4 for ; Mon, 10 May 2021 08:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D87F0613B6 for ; Mon, 10 May 2021 08:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbhEJIB6 (ORCPT ); Mon, 10 May 2021 04:01:58 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:55257 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbhEJIBz (ORCPT ); Mon, 10 May 2021 04:01:55 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 3890C240006; Mon, 10 May 2021 08:00:46 +0000 (UTC) Date: Mon, 10 May 2021 10:00:46 +0200 From: Alexandre Belloni To: Samuel Holland Cc: Maxime Ripard , Alessandro Zummo , Chen-Yu Tsai , Jernej Skrabec , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sun6i: Add NVMEM provider Message-ID: References: <20210419014549.26900-1-samuel@sholland.org> <20210430090206.lybmygrt636nysoc@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 09/05/2021 22:39:30-0500, Samuel Holland wrote: > On 4/30/21 4:02 AM, Maxime Ripard wrote: > > Hi, > > > > On Sun, Apr 18, 2021 at 08:45:49PM -0500, Samuel Holland wrote: > >> The sun6i RTC provides 32 bytes of general-purpose data registers. > >> They can be used to save data in the always-on RTC power domain. > >> The registers are writable via 32-bit MMIO accesses only. > >> > >> Expose the region as a NVMEM provider so it can be used by userspace and > >> other drivers. > >> > >> Signed-off-by: Samuel Holland > > > > As far as I understood, you want to use those registers to implement > > super-standby? If so, while it makes sense for the kernel to be able to > > be able to write to those registers, I guess it would be a bit unwise to > > allow the userspace to access it? > > I want the user to be able to pass information to the bootloader (to > select a boot device, e.g. reboot to FEL). I also want the user to be > able to read data stored to these registers by system firmware (e.g. > crust writes exception information there). It's not really related to > standby. > > I would want to stack a nvmem-reboot-mode on top to give friendlier > names to some of the numbers, but I don't see a problem with root having > direct access to the registers. It's no different from /dev/nvram > providing access to the PC CMOS RAM. > (which is deprecated in favor of nvmem) -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com