Re: [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic

Alexandre Belloni
2021-09-20T20:07:13Z

On 20/09/2021 19:03:49+0000, Will McVicker wrote:
> Switches the default config logic of HAVE_S3C_RTC to use "default y if
> (ARCH_EXYNOS && RTC_CLASS)" versus having ARCH_EXYNOS directly select
> it. This provides vendors flexibility to disable the config if desired
> or modularize it in the presence of a generic kernel.
>
> Verified this change doesn't impact the .config.
>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
> arch/arm64/Kconfig.platforms | 1 -
> drivers/rtc/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index a884e5da8b0f..f9f829aab511 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -91,7 +91,6 @@ config ARCH_BRCMSTB
>
> config ARCH_EXYNOS
> bool "ARMv8 based Samsung Exynos SoC family"
> - select HAVE_S3C_RTC if RTC_CLASS
> select PINCTRL
> select PM_GENERIC_DOMAINS if PM
> help
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index e1bc5214494e..40afdb37d2a5 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1406,6 +1406,7 @@ config RTC_DRV_OMAP
>
> config HAVE_S3C_RTC
> bool
> + default y if (ARCH_EXYNOS && RTC_CLASS)
> help
> This will include RTC support for Samsung SoCs. If
> you want to include RTC support for any machine, kindly
> --
> 2.33.0.464.g1972c5931b-goog
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering