Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs

Krzysztof Kozlowski
2021-09-21T07:20:07Z

On 20/09/2021 21:03, Will McVicker wrote:
> This patch series tries to address the issue of ARCH_EXYNOS force selecting
> a handful of drivers without allowing the vendor to override any of the
> default configs. This takes away from the flexibilty of compiling a generic
> kernel with exynos kernel modules. For example, it doesn't allow vendors to
> modularize these drivers out of the core kernel in order to share a generic
> kernel image across multiple devices that require device-specific kernel
> modules.

You do not address the issue in these patches. The problem you describe
is that drivers are not modules and you are not changing them into modules.

>
> To address this without impacting the existing behavior, this series
> switches the default config logic for the offending configs to use "default
> y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have
> verified that these patches do not impact the default aarch64 .config.

Yep, this is what you did but it does not match the described problem.
You are not solving it but doing something else.

>
> Will McVicker (4):
> clk: samsung: change COMMON_CLK_SAMSUNG default config logic
> soc: samsung: change SOC_SAMSUNG default config logic
> pinctrl: samsung: change PINCTRL_EXYNOS default config logic
> rtc: change HAVE_S3C_RTC default config logic
>

I received only two patches from this set. Please resend following
get_maintainers.pl script.

Best regards,
Krzysztof