From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wilken Gottwalt <wilken.gottwalt@posteo.net>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Joerg Reiling <joerg.reiling@jenoptik.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: rtc-isl12022: add isl12020 device support
Date: Thu, 23 Sep 2021 17:36:55 +0200 [thread overview]
Message-ID: <YUyfF5VRfOkdC4wn@piout.net> (raw)
In-Reply-To: <YUx43WuvwrYIvjxe@monster.powergraphx.local>
Hi,
On 23/09/2021 12:53:49+0000, Wilken Gottwalt wrote:
> Adds the isl12020 device, which is fully compatible to isl12022.
>
Do you know what is differing between both parts? If there is nothing
relevant to linux, maybe we could just avoid adding a new compatible
string.
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
> Signed-off-by: Joerg Reiling <joerg.reiling@jenoptik.com>
> ---
> drivers/rtc/rtc-isl12022.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c
> index 961bd5d1d109..c62770ec99c9 100644
> --- a/drivers/rtc/rtc-isl12022.c
> +++ b/drivers/rtc/rtc-isl12022.c
> @@ -257,6 +257,8 @@ static int isl12022_probe(struct i2c_client *client,
> static const struct of_device_id isl12022_dt_match[] = {
> { .compatible = "isl,isl12022" }, /* for backward compat., don't use */
> { .compatible = "isil,isl12022" },
> + { .compatible = "isl,isl12020" }, /* for backward compat., don't use */
Please, do not add this compatible string.
> + { .compatible = "isil,isl12020" },
You also need to document this string in Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> { },
> };
> MODULE_DEVICE_TABLE(of, isl12022_dt_match);
> @@ -264,6 +266,7 @@ MODULE_DEVICE_TABLE(of, isl12022_dt_match);
>
> static const struct i2c_device_id isl12022_id[] = {
> { "isl12022", 0 },
> + { "isl12020", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, isl12022_id);
> --
> 2.33.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-09-23 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:53 [PATCH] rtc: rtc-isl12022: add isl12020 device support Wilken Gottwalt
2021-09-23 15:36 ` Alexandre Belloni [this message]
2021-09-23 16:39 ` Wilken Gottwalt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUyfF5VRfOkdC4wn@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=joerg.reiling@jenoptik.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox