From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F1BC433EF for ; Mon, 18 Oct 2021 18:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98B0F60E09 for ; Mon, 18 Oct 2021 18:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbhJRS7b (ORCPT ); Mon, 18 Oct 2021 14:59:31 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:58791 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbhJRS7a (ORCPT ); Mon, 18 Oct 2021 14:59:30 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D2BAC240006; Mon, 18 Oct 2021 18:57:16 +0000 (UTC) Date: Mon, 18 Oct 2021 20:57:16 +0200 From: Alexandre Belloni To: Sam Protsenko Cc: Alessandro Zummo , Krzysztof Kozlowski , linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: s3c: Remove usage of devm_rtc_device_register() Message-ID: References: <20211018173201.2166-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018173201.2166-1-semen.protsenko@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 18/10/2021 20:32:01+0300, Sam Protsenko wrote: > devm_rtc_device_register() is deprecated. Use devm_rtc_allocate_device() > and devm_rtc_register_device() API instead. > If you do that, please also set the range properly, either in the same patch or as a follow-up. > Signed-off-by: Sam Protsenko > --- > drivers/rtc/rtc-s3c.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index e57d3ca70a78..10e591794276 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -447,15 +447,18 @@ static int s3c_rtc_probe(struct platform_device *pdev) > > device_init_wakeup(&pdev->dev, 1); > > - /* register RTC and exit */ > - info->rtc = devm_rtc_device_register(&pdev->dev, "s3c", &s3c_rtcops, > - THIS_MODULE); > + info->rtc = devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(info->rtc)) { > - dev_err(&pdev->dev, "cannot attach rtc\n"); > ret = PTR_ERR(info->rtc); > goto err_nortc; > } > > + info->rtc->ops = &s3c_rtcops; > + > + ret = devm_rtc_register_device(info->rtc); > + if (ret) > + goto err_nortc; > + > ret = devm_request_irq(&pdev->dev, info->irq_alarm, s3c_rtc_alarmirq, > 0, "s3c2410-rtc alarm", info); > if (ret) { > -- > 2.30.2 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com